Remove temp golden config after reload config with golden config.#14077
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Aug 13, 2024
Merged
Conversation
ZhaohuiS
reviewed
Aug 13, 2024
Gfrom2016
reviewed
Aug 13, 2024
Gfrom2016
approved these changes
Aug 13, 2024
ZhaohuiS
approved these changes
Aug 13, 2024
Contributor
|
Hi @StormLiangMS we also need this in 202405. Could you please cherry-pick? |
Contributor
|
@liuh-80 should we cherry pick it for 202311 as well? |
Contributor
|
Hi @StormLiangMS and @liuh-80, 202405 nightly test is breaking due to this, could we cherry-pick this to 202405? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 26, 2024
…nic-net#14077) Remove temp golden config after reload config with golden config. Why I did it test_fallback_to_local_authorization_with_config_reload test case will reload config with AAA enabled. After this test case, the golden config file will left on device, when some other code reload config, device will enable AAA and block other login again. Work item tracking Microsoft ADO: 28871521 How I did it Remove temp golden config after reload config with golden config. How to verify it Pass all test case.
Collaborator
|
Cherry-pick PR to 202405: #14751 |
9 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 26, 2024
…nic-net#14077) Remove temp golden config after reload config with golden config. Why I did it test_fallback_to_local_authorization_with_config_reload test case will reload config with AAA enabled. After this test case, the golden config file will left on device, when some other code reload config, device will enable AAA and block other login again. Work item tracking Microsoft ADO: 28871521 How I did it Remove temp golden config after reload config with golden config. How to verify it Pass all test case.
Collaborator
|
Cherry-pick PR to 202311: #14752 |
9 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Sep 26, 2024
…4077) Remove temp golden config after reload config with golden config. Why I did it test_fallback_to_local_authorization_with_config_reload test case will reload config with AAA enabled. After this test case, the golden config file will left on device, when some other code reload config, device will enable AAA and block other login again. Work item tracking Microsoft ADO: 28871521 How I did it Remove temp golden config after reload config with golden config. How to verify it Pass all test case.
mssonicbld
pushed a commit
that referenced
this pull request
Sep 26, 2024
…4077) Remove temp golden config after reload config with golden config. Why I did it test_fallback_to_local_authorization_with_config_reload test case will reload config with AAA enabled. After this test case, the golden config file will left on device, when some other code reload config, device will enable AAA and block other login again. Work item tracking Microsoft ADO: 28871521 How I did it Remove temp golden config after reload config with golden config. How to verify it Pass all test case.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202311 branch
Created PR to 202405 branch
labels
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…nic-net#14077) Remove temp golden config after reload config with golden config. Why I did it test_fallback_to_local_authorization_with_config_reload test case will reload config with AAA enabled. After this test case, the golden config file will left on device, when some other code reload config, device will enable AAA and block other login again. Work item tracking Microsoft ADO: 28871521 How I did it Remove temp golden config after reload config with golden config. How to verify it Pass all test case.
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
…nic-net#14077) Remove temp golden config after reload config with golden config. Why I did it test_fallback_to_local_authorization_with_config_reload test case will reload config with AAA enabled. After this test case, the golden config file will left on device, when some other code reload config, device will enable AAA and block other login again. Work item tracking Microsoft ADO: 28871521 How I did it Remove temp golden config after reload config with golden config. How to verify it Pass all test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove temp golden config after reload config with golden config.
Why I did it
test_fallback_to_local_authorization_with_config_reload test case will reload config with AAA enabled.
After this test case, the golden config file will left on device, when some other code reload config, device will enable AAA and block other login again.
Work item tracking
How I did it
Remove temp golden config after reload config with golden config.
How to verify it
Pass all test case.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Remove temp golden config after reload config with golden config.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)