Skip to content

added log ignore to ignore BFD session creation failure logs. On mlnx…#14025

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
siqbal1986:vxlan_ecmp_mlnx_log_ignore
Aug 28, 2024
Merged

added log ignore to ignore BFD session creation failure logs. On mlnx…#14025
bingwang-ms merged 1 commit intosonic-net:masterfrom
siqbal1986:vxlan_ecmp_mlnx_log_ignore

Conversation

@siqbal1986
Copy link
Copy Markdown
Contributor

@siqbal1986 siqbal1986 commented Aug 7, 2024

On Mlnx paltforms, while running this test BFD session creation can fail sometime resulting in the following logs.
THe syncd retries in such a case and is able to create the BFD session subsequently. So these errors can be ignored.
E Jun 9 14:12:41.474573 strtk5-msn2700-06 ERR kernel: [35758.641097] sxd_kernel: [error] Failed to bind BFD socket to local_addr (ip:10.1.0.32 ,port:49171) (err:-98). E E Jun 9 14:12:41.474603 strtk5-msn2700-06 ERR kernel: [35758.760511] sxd_kernel: [error] Failed to create TX socket for session 8165 (err:-5). E E Jun 9 14:12:41.552788 strtk5-msn2700-06 ERR kernel: [35758.854304] sxd_kernel: [error] Parsing BFD command 0 failed (err:-5). E E Jun 9 14:12:41.553068 strtk5-msn2700-06 ERR syncd#SDK: [BFD.ERR] ioctl failed, error description: Input/output error E E Jun 9 14:12:41.553203 strtk5-msn2700-06 ERR syncd#SDK: [CORE_API.ERR] Failed in bfd_offload_set() , error: Internal Error E E Jun 9 14:12:41.553454 strtk5-msn2700-06 ERR syncd#SDK: [SAI_BFD.ERR] ./src/mlnx_sai_bfd.c[393]- mlnx_set_offload_bfd_tx_session: Error create TX BFD session: Internal Error. E E Jun 9 14:12:41.554748 strtk5-msn2700-06 ERR syncd#SDK: :- sendApiResponse: api SAI_COMMON_API_CREATE failed in syncd mode: SAI_STATUS_FAILURE E E Jun 9 14:12:41.555685 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_TYPE: SAI_BFD_SESSION_TYPE_ASYNC_ACTIVE E E Jun 9 14:12:41.555751 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_LOCAL_DISCRIMINATOR: 20 E E Jun 9 14:12:41.555792 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_UDP_SRC_PORT: 49171 E E Jun 9 14:12:41.555891 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_REMOTE_DISCRIMINATOR: 0 E E Jun 9 14:12:41.556028 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_BFD_ENCAPSULATION_TYPE: SAI_BFD_ENCAPSULATION_TYPE_NONE E E Jun 9 14:12:41.556076 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_IPHDR_VERSION: 4 E E Jun 9 14:12:41.556191 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_SRC_IP_ADDRESS: 10.1.0.32 E E Jun 9 14:12:41.556239 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_DST_IP_ADDRESS: 100.0.27.1 E E Jun 9 14:12:41.556322 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_MIN_TX: 1000000 E E Jun 9 14:12:41.556451 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_MIN_RX: 1000000 E E Jun 9 14:12:41.556451 strtk5-msn2700-06 ERR swss#orchagent: :- create: create status: SAI_STATUS_FAILURE E E Jun 9 14:12:41.556510 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_MULTIPLIER: 10 E E Jun 9 14:12:41.556549 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_TOS: 192 E E Jun 9 14:12:41.556627 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_MULTIHOP: true E E Jun 9 14:12:41.556669 strtk5-msn2700-06 ERR syncd#SDK: :- processQuadEvent: attr: SAI_BFD_SESSION_ATTR_VIRTUAL_ROUTER: oid:0x3000000000002

Description of PR

Summary:
Fixes # (issue)

Type of change

Testfix

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

This PR is added to ignore the BFD session creation failure messages as these messages lead to test failure due to unexpected logs. The Mlnx platform has the capability to retry the BFD session creation.The 2nd attempt passes and the test works fine,
In the event the platform fails to create the BFD session, the test would eventually fail so by ignoring these these logs we are not impacting the test itself.

How did you do it?

Added log ignore for these messages.

How did you verify/test it?

Ran this multiple times to check for failure.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

… platofrms, the syncd retries in sucha a case and passes.
@wsycqyz
Copy link
Copy Markdown
Contributor

wsycqyz commented Aug 9, 2024

I suggest we write something in "What is the motivation for this PR?", "How did you do it?" and "How did you verify/test it?
" section.

@bingwang-ms bingwang-ms merged commit 00aa430 into sonic-net:master Aug 28, 2024
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Aug 28, 2024
… platofrms, the syncd retries in sucha a case and passes. (sonic-net#14025)
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202405: #14280

mssonicbld pushed a commit that referenced this pull request Sep 2, 2024
… platofrms, the syncd retries in sucha a case and passes. (#14025)
arista-hpandya pushed a commit to arista-hpandya/sonic-mgmt that referenced this pull request Oct 2, 2024
… platofrms, the syncd retries in sucha a case and passes. (sonic-net#14025)
vikshaw-Nokia pushed a commit to vikshaw-Nokia/sonic-mgmt that referenced this pull request Oct 23, 2024
… platofrms, the syncd retries in sucha a case and passes. (sonic-net#14025)
mssonicbld added a commit to mssonicbld/sonic-mgmt.msft that referenced this pull request Jul 9, 2025
<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
On Nvidia paltforms, while running this test BFD session creation can fail sometime resulting in some syslog errors.
THe syncd retries in such a case and is able to create the BFD session subsequently. So these errors can be ignored.

There is already a PR handling the same errors in tests/vxlan/test_vxlan_ecmp.py: sonic-net/sonic-mgmt#14025

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [x] 202411

### Approach
#### What is the motivation for this PR?

#### How did you do it?

#### How did you verify/test it?

#### Any platform specific information?
Tested on Nvidia plarforms, errors can be ignored.
#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
mssonicbld added a commit to Azure/sonic-mgmt.msft that referenced this pull request Jul 9, 2025
…#509)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
On Nvidia paltforms, while running this test BFD session creation can fail sometime resulting in some syslog errors.
THe syncd retries in such a case and is able to create the BFD session subsequently. So these errors can be ignored.

There is already a PR handling the same errors in tests/vxlan/test_vxlan_ecmp.py: sonic-net/sonic-mgmt#14025

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [x] 202411

### Approach
#### What is the motivation for this PR?

#### How did you do it?

#### How did you verify/test it?

#### Any platform specific information?
Tested on Nvidia plarforms, errors can be ignored.
#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants