Degrade PFC storm detection in PFCWD all ports storm test#13976
Merged
bingwang-ms merged 5 commits intosonic-net:masterfrom Aug 13, 2024
Merged
Conversation
nhe-NV
reviewed
Aug 5, 2024
Contributor
nhe-NV
left a comment
nhe-NV
left a comment
There was a problem hiding this comment.
As this solution is to workaround the fanout which is not using the mellanox switch, suggest only apply this solution when the fanout is not mellanox switch(onxy or sonic)
Collaborator
Author
Added a skip statement for Mellanox leaf fanout. |
Collaborator
Author
|
@nhe-NV Can you help review again? Thanks |
nhe-NV
approved these changes
Aug 13, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 13, 2024
…13976) * Degrade PFC storm detection logic in pfcwd_all_port_storm test
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 13, 2024
…13976) * Degrade PFC storm detection logic in pfcwd_all_port_storm test
Collaborator
|
Cherry-pick PR to 202311: #14093 |
Collaborator
|
Cherry-pick PR to 202405: #14092 |
This was referenced Aug 13, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Aug 13, 2024
* Degrade PFC storm detection logic in pfcwd_all_port_storm test
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
bingwang-ms
added a commit
that referenced
this pull request
Sep 13, 2024
…14092) * Degrade PFC storm detection logic in pfcwd_all_port_storm test Co-authored-by: bingwang-ms <[email protected]>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…13976) * Degrade PFC storm detection logic in pfcwd_all_port_storm test
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
…13976) * Degrade PFC storm detection logic in pfcwd_all_port_storm test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR is to degrade the PFC storm detection logic on Mellanox platform to workaround the performance issue of leaf-fanout switch.
The
test_pfcwd_all_port_storm.pyis failing because leaf fanout switch can't send enough PFC pause frames to trigger PFC storm after PR sonic-net/sonic-swss#3036 .There are different workaround method on Onyx and Mellanox-SONiC leaf-fanout, but there is no workaround for DUT that is not connected to Mellanox leaf-fanout switch.
This PR workaround the issue by copying the old
pfc_detect_mellanox.luato degrade the PFC storm detection logic to make PFC storm easier to be triggered.As the test is to verify there is no issue when PFCWD is firing on all ports, this change doesn't change the coverage of test.
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR workaround the issue by copying the old
pfc_detect_mellanox.luato degrade the PFC storm detection logic to make PFC storm easier to be triggered.How did you do it?
Cppy the old
pfc_detect_mellanox.luato degrade the PFC storm detection logic.How did you verify/test it?
The change is verified on a Mellanox DUT.
Any platform specific information?
Mellanox platform specific.
Supported testbed topology if it's a new test case?
Not a new test case.
Documentation