[action] [PR:13793] Increase post-PDU state change delay to allow all PSUs to react#13832
Merged
mssonicbld merged 1 commit intosonic-net:202311from Jul 26, 2024
Merged
Conversation
…c-net#13793) * Increase post-PDU state change delay to allow all PSUs to react * Revert delay increase for 'turn_all_outlets_on'
8 tasks
Collaborator
Author
|
Original PR: #13793 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Increase delay between PDU state change and reading PSU details to 10 seconds (previously 5).
Type of change
Back port request
Approach
What is the motivation for this PR?
10 second delay between PDU state change and accessing PSU details is not always enough. The time needed depends on PDU hardware, psud update interval, and PSU hardware. Increasing to 20 seconds allows extra time for the PDU to apply a state change and PSU to reflect it, which MSFT has validated and found sufficient.
How did you do it?
Increase post-PDU state change delays to 20 seconds (previously 10 seconds). This is especially important anywhere the PDU state is changed to "on".
How did you verify/test it?
MSFT verified by setting the delay to 20 seconds since Cisco was unable to reproduce with our PDU hardware.