[qos/t2] support single ASIC linecards#13700
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jul 24, 2024
Merged
Conversation
sonic-net#11000 only can handle multi-asic linecards. This fixes the limitation foro single ASIC linecards.
Contributor
Author
|
@wenyiz2021 @arlakshm @ysmanman for awareness |
arlakshm
approved these changes
Jul 17, 2024
Contributor
wenyiz2021
approved these changes
Jul 17, 2024
wenyiz2021
added
Request for 202205 branch
Request for 202305 branch
Request for master
and removed
Request for master
labels
Contributor
Author
|
@wenyiz2021 can you help merge this fix? |
Contributor
Author
|
@wenyiz2021 can you help add a label to |
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
sonic-net#11000 only can handle multi-asic linecards. This fixes the limitation foro single ASIC linecards.
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
sonic-net#11000 only can handle multi-asic linecards. This fixes the limitation foro single ASIC linecards.
Contributor
Author
|
@arlakshm @wenyiz2021 can this PR be cherry-picked to 202405 soon? |
Contributor
|
@yejianquan can you help port this to 202405? thanks |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 22, 2024
sonic-net#11000 only can handle multi-asic linecards. This fixes the limitation foro single ASIC linecards.
Collaborator
|
Cherry-pick PR to 202405: #15697 |
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 22, 2024
#11000 only can handle multi-asic linecards. This fixes the limitation foro single ASIC linecards.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
patrickmacarthur
added a commit
to patrickmacarthur/sonic-mgmt
that referenced
this pull request
Nov 22, 2024
We are seeing UnboundLocalError when running sonic-mgmt tests against a single-ASIC linecard: ``` UnboundLocalError: local variable 'dst_sys_port_id' referenced before assignment ``` Upon further investigation, this was determined to be happening because a previous attempt to fix this issue (PR sonic-net#13700) completely omitted the ASIC prefix, but the entries in SYSTEM_PORT in config_db do have an Asic0 prefix even on a single ASIC DUT. Resolve this by specifically adding the Asic0 prefix in the case of a single-ASIC T2 DUT, instead of leaving the prefix out. Tested by manually running qos tests on a T2 single ASIC DUT with these changes.
8 tasks
rlhui
pushed a commit
that referenced
this pull request
Jan 7, 2025
) We are seeing UnboundLocalError when running sonic-mgmt tests against a single-ASIC linecard: ``` UnboundLocalError: local variable 'dst_sys_port_id' referenced before assignment ``` Upon further investigation, this was determined to be happening because a previous attempt to fix this issue (PR #13700) completely omitted the ASIC prefix, but the entries in SYSTEM_PORT in config_db do have an Asic0 prefix even on a single ASIC DUT. Resolve this by specifically adding the Asic0 prefix in the case of a single-ASIC T2 DUT, instead of leaving the prefix out. Tested by manually running qos tests on a T2 single ASIC DUT with these changes.
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jan 9, 2025
…ic-net#15708) We are seeing UnboundLocalError when running sonic-mgmt tests against a single-ASIC linecard: ``` UnboundLocalError: local variable 'dst_sys_port_id' referenced before assignment ``` Upon further investigation, this was determined to be happening because a previous attempt to fix this issue (PR sonic-net#13700) completely omitted the ASIC prefix, but the entries in SYSTEM_PORT in config_db do have an Asic0 prefix even on a single ASIC DUT. Resolve this by specifically adding the Asic0 prefix in the case of a single-ASIC T2 DUT, instead of leaving the prefix out. Tested by manually running qos tests on a T2 single ASIC DUT with these changes.
yejianquan
pushed a commit
to yejianquan/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
…ic-net#15708) We are seeing UnboundLocalError when running sonic-mgmt tests against a single-ASIC linecard: ``` UnboundLocalError: local variable 'dst_sys_port_id' referenced before assignment ``` Upon further investigation, this was determined to be happening because a previous attempt to fix this issue (PR sonic-net#13700) completely omitted the ASIC prefix, but the entries in SYSTEM_PORT in config_db do have an Asic0 prefix even on a single ASIC DUT. Resolve this by specifically adding the Asic0 prefix in the case of a single-ASIC T2 DUT, instead of leaving the prefix out. Tested by manually running qos tests on a T2 single ASIC DUT with these changes.
yejianquan
added a commit
to yejianquan/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
sonic-mgmt: Fix namespace issues for qos tests on T2 single ASIC (sonic-net#15708) Approach What is the motivation for this PR? We are seeing UnboundLocalError when running sonic-mgmt tests against a single-ASIC linecard: UnboundLocalError: local variable 'dst_sys_port_id' referenced before assignment Upon further investigation, this was determined to be happening because a previous attempt to fix this issue (PR sonic-net#13700) completely omitted the ASIC prefix, but the entries in SYSTEM_PORT in config_db do have an Asic0 prefix even on a single ASIC DUT. How did you do it? Resolve this by specifically adding the Asic0 prefix in the case of a single-ASIC T2 DUT, instead of leaving the prefix out. How did you verify/test it? Tested by manually running qos tests on a T2 single ASIC DUT with these changes. co-authorized by: jianquanye@microsoft.com
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
…ic-net#15708) We are seeing UnboundLocalError when running sonic-mgmt tests against a single-ASIC linecard: ``` UnboundLocalError: local variable 'dst_sys_port_id' referenced before assignment ``` Upon further investigation, this was determined to be happening because a previous attempt to fix this issue (PR sonic-net#13700) completely omitted the ASIC prefix, but the entries in SYSTEM_PORT in config_db do have an Asic0 prefix even on a single ASIC DUT. Resolve this by specifically adding the Asic0 prefix in the case of a single-ASIC T2 DUT, instead of leaving the prefix out. Tested by manually running qos tests on a T2 single ASIC DUT with these changes.
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
…ic-net#15708) We are seeing UnboundLocalError when running sonic-mgmt tests against a single-ASIC linecard: ``` UnboundLocalError: local variable 'dst_sys_port_id' referenced before assignment ``` Upon further investigation, this was determined to be happening because a previous attempt to fix this issue (PR sonic-net#13700) completely omitted the ASIC prefix, but the entries in SYSTEM_PORT in config_db do have an Asic0 prefix even on a single ASIC DUT. Resolve this by specifically adding the Asic0 prefix in the case of a single-ASIC T2 DUT, instead of leaving the prefix out. Tested by manually running qos tests on a T2 single ASIC DUT with these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
#11000 only can handle multi-asic linecards. This fixes the limitation foro single ASIC linecards.
Summary:
Fixes # #13676
Type of change
Back port request