Skip to content

Changes for testing Multi NPU platforms#1369

Merged
lguohan merged 3 commits intosonic-net:masterfrom
arlakshm:multi_npu_test_changes
Mar 16, 2020
Merged

Changes for testing Multi NPU platforms#1369
lguohan merged 3 commits intosonic-net:masterfrom
arlakshm:multi_npu_test_changes

Conversation

@arlakshm
Copy link
Contributor

@arlakshm arlakshm commented Feb 6, 2020

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com

Description of PR

This PR has the changes to support testing for Multi NPU SONiC platforms
Changes done:

  • Add a new option to the bgp_fact module to get the bgp facts from multiple bgp dockers
  • Add an option "filename" in the config_facts to the pass the config_db.json file
  • changes to the SonicHost class to detect if the platform is single or multi NPU
  • changes to the sanity check and bgp_facts tests to test multi NPU platforms

Summary:
Fixes # (issue)

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • [-] Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

Verifyied the basic sanity and test_bgp_fact tests run properly on single and multi NPU platforms.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Changes done:
 - Add a new option to the bgp_fact module to get the bgp facts from multiple bgp dockers
 - Add an option "filename" in the config_facts to the pass the config_db.json file
 - changes to the SonicHost class to detect if the platform is single or multi NPU
 - changes to the sanity check and bgp_facts tests to test multi NPU platforms

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
@arlakshm arlakshm requested a review from lguohan February 6, 2020 09:58
@lguohan
Copy link
Contributor

lguohan commented Feb 10, 2020

can you give command line how to use it when testing multi npu platforms?

@arlakshm
Copy link
Contributor Author

@lguohan , the command is same as the one used currently for single NPU platforms, no new command-line arguments are added. I used the following command

py.test --inventory $INVT --host-pattern all --user admin --testbed $TB --testbed_file $TBFILE --junitxml=tr.xml test_bgp_fact.py

@arlakshm arlakshm requested a review from yxieca February 27, 2020 23:26
@yxieca
Copy link
Collaborator

yxieca commented Mar 2, 2020

Can you upload a test result output too?

@arlakshm
Copy link
Contributor Author

arlakshm commented Mar 2, 2020

@yxieca, Please find the logs below
test_bgp_facts_results.zip

@yxieca
Copy link
Collaborator

yxieca commented Mar 3, 2020

Why didn't I find keyword 'num_npu' in the xml output? Should I expect to see it? Also, the filename is tr.xml.xml. Is that because you manually created this file? :-)
Hi Ying, my apologies I uploaded the wrong results. I had renamed the file locally from tr.xml to test_bgp_facts.xml for clarity :)

test_bgp_facts.zip

@lguohan lguohan merged commit 9f6506e into sonic-net:master Mar 16, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
* c2fb282 2021-01-29 | [ecnconfig] Allow ecn unit test to run without sudo (sonic-net#1390) [Neetha John]
* 6cc635b 2021-01-29 | [sonic-installer] Add information to syslog (sonic-net#1369) [Dmytro]
* 7a8024a 2021-01-27 | Prevent user from adding more then a single untagged VLAN to an interface (sonic-net#1382) [Eran Dahan]
* 41e62c6 2021-01-26 | [pcieutil] Add 'pcie-aer' sub-command to display AER stats (sonic-net#1169) [Arun Saravanan Balachandran]
* 47f412b 2021-01-26 | Improve robustness of consutil plugin loading (sonic-net#1353) [Samuel Angebault]
* 64aa1b8 2021-01-25 | [show] Fix warnings, related to gearbox, while show commands execution (sonic-net#1343) [maksymbelei95]
* ff226d0 2021-01-25 | Prevent configuring IP interface on a port which is a member of VLAN (sonic-net#1374) [Eran Dahan]
* f1522b9 2021-01-21 | [config_mgmt.py]: Set leaf-list to empty list while port breakout. (sonic-net#1268) [Praveen Chaudhary]
* 99c05d5 2021-01-21 | add vlan_intf_object only if there are ipv4 or ipv6 mappings (sonic-net#1377) [Sumukha Tumkur Vani]
* b082684 2021-01-21 | [ecn] Add tests for ecnconfig command (sonic-net#1372) [Neetha John]
* 23e0920 2021-01-21 | [sfpshow] Enhance QSFP-DD DOM information (sonic-net#1207) [shlomibitton]
* f4edba1 2021-01-20 | [ecnconfig] handle backend port names when extracting port I/F ID from the port name (sonic-net#1361) [Mahesh Maddikayala]

Signed-off-by: Danny Allen <daall@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants