Fix: Fix NTP config long jump test failure issue#13671
Merged
rlhui merged 3 commits intosonic-net:masterfrom Jul 17, 2024
wumiaont:ntp
Merged
Fix: Fix NTP config long jump test failure issue#13671rlhui merged 3 commits intosonic-net:masterfrom wumiaont:ntp
rlhui merged 3 commits intosonic-net:masterfrom
wumiaont:ntp
Conversation
wsycqyz
approved these changes
Jul 16, 2024
Contributor
|
I am ok with the PR. Do we need this PR in 2024 or 2023 branch? |
Contributor
Author
We need for 202405. Not sure about 202305. |
Contributor
Author
|
@wsycqyz Can you review the PR again? Found logic issue in test_ntp_long_jump_disabled and fixed that. Also found this test passes after fix so we need to remove the xfail from test_mark_condition.py for test_ntp_long_jump_disabled. |
wsycqyz
approved these changes
Jul 17, 2024
rlhui
approved these changes
Jul 17, 2024
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Jul 18, 2024
The restart command needs to be run using root privilege.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 2, 2024
The restart command needs to be run using root privilege.
Collaborator
|
Cherry-pick PR to 202405: #13947 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 3, 2024
The restart command needs to be run using root privilege.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Contributor
|
@yxieca Please help to approve the request label |
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
The restart command needs to be run using root privilege.
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
The restart command needs to be run using root privilege.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
NTP test_ntp_long_jump_enabled and test_ntp_long_jump_disabled tests are failing for master/202405 branch
Summary:
Fixes # (issue)
The restart command needs to be run using root privilege.
Type of change
Back port request
How did you do it?
How did you verify/test it?
Run NTP test_ntp_long_jump_enabled and test_ntp_long_jump_disabled test with fix. They all passed.