Skip to content

[dhcp-relay] Make mac addresses of ptf interfaces unique#1366

Merged
lguohan merged 4 commits intosonic-net:masterfrom
tahmed-dev:taahme/change-mac-address-b4-test-run
Feb 5, 2020
Merged

[dhcp-relay] Make mac addresses of ptf interfaces unique#1366
lguohan merged 4 commits intosonic-net:masterfrom
tahmed-dev:taahme/change-mac-address-b4-test-run

Conversation

@tahmed-dev
Copy link
Contributor

DHCP relay agent uses the mac address to find where the DHCP packet
came from. When having more than one lan, the test fails as all
ptf interfaces use the same mac address. DHCP packet received on
ptf host are not counted as option 82 is not matching expected packets.

signed-of-by: Tamer Ahmed [email protected]

Description of PR

Summary:
Fixes # (issue)

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

DHCP relay agent uses the mac address to find where the DHCP packet
came from. When having more than one lan, the test fails as all
ptf interfaces use the same mac address. DHCP packet received on
ptf host are not counted as option 82 is not matching expected packets.

signed-of-by: Tamer Ahmed <[email protected]>
@tahmed-dev tahmed-dev changed the title [dhcp-relay] Change mac addresses of ptf interfaces [dhcp-relay] Make mac addresses of ptf interfaces unique Feb 5, 2020
@tahmed-dev tahmed-dev requested a review from jleveque February 5, 2020 01:53
@tahmed-dev tahmed-dev requested a review from jleveque February 5, 2020 02:09
@lguohan lguohan merged commit 9bb5a45 into sonic-net:master Feb 5, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…et#7487)

* [202012][swss/swss-common/utilities/kernel] Update submodule

sonic-swss:
- [Monitor Vlan] Fix a typo in hostif (sonic-net#1722)
- Update pool sizes during initialization from timer only (sonic-net#1708)
- [SflowMgr] SamplingRate Update by Speed Change Added (sonic-net#1721)

sonic-swss-common:
- [swss-common] Add MUX Metrics Table (sonic-net#482)
- [azp] Purge swss before installing the newly built deb package (sonic-net#472)

sonic-utilities:
- disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569)
- No more IP validation as it is more likely a URL (sonic-net#1555)
- Stop PMON docker before cold and soft reboots (sonic-net#1514)
- Add soft-reboot reboot type (sonic-net#1453)
- [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519)
- sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553)
- Fix unsupported fs.squashfs extraction in sonic-installer (sonic-net#1366)
- [show][config] cli support for firmware upgrade on Y-Cable (sonic-net#1528) (sonic-net#1558)

sonic-linux-kernel:
- [Mellanox] backport kernel patches for hw-management 7.0100.2303 (sonic-net#211)

Signed-off-by: Danny Allen <[email protected]>

* Update utilities w/ build fix
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
 Remove 00-copp.config.json from swss debian package. (sonic-net#1366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants