Skip to content

[action] [PR:13483] [Snappi] - fixing swss service restart logic for basic PFCWD testcases in multi-asic environment#13519

Merged
mssonicbld merged 1 commit intosonic-net:202405from
mssonicbld:cherry/202405/13483
Jul 2, 2024
Merged

[action] [PR:13483] [Snappi] - fixing swss service restart logic for basic PFCWD testcases in multi-asic environment#13519
mssonicbld merged 1 commit intosonic-net:202405from
mssonicbld:cherry/202405/13483

Conversation

@mssonicbld
Copy link
Collaborator

Description of PR

The existing PFCWD basic testcases have restart SWSS service testcases.

However, these testcases do not address the multi-asic environment. The pull-request addresses this.

Summary:
Fixes # (issue)
The fix finds out the DUT and interfaces used in the test and based on that selects swss@0 or swss@1 to restart. The fix first verifies if the platform field exists and if yes, is set to 'broadcom-dnx' field. If this is not true, then code executes the default testcase.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

To address the multi-asic environment scenario and select appropriate SWSS depending upon the DUT-interface selected for the test.

How did you do it?

  • Finding the DUT-interface used in the test.
  • For Single line card - Single ASIC, the DUT will be same and interfaces will be from same ASIC. So only single swss is selected.
  • For Single line card - Multi ASIC, DUT is same but interfaces will be from different ASIC and hence two SWSS instances are selected. Same logic for multiple line card scenario.

How did you verify/test it?

  • Ran the test on local setup.

Logs for single line card single ASIC:

15:33:49 test_multidut_pfcwd_basic_with_snappi.te L0574 INFO | Issuing a restart of service swss@0 on the dut ixre-egl-board72
15:35:15 test_multidut_pfcwd_basic_with_snappi.te L0577 INFO | Wait until the system is stable

Logs for single line card multiple ASIC:

15:47:39 test_multidut_pfcwd_basic_with_snappi.te L0574 INFO | Issuing a restart of service swss@1 on the dut ixre-egl-board71
15:48:59 test_multidut_pfcwd_basic_with_snappi.te L0577 INFO | Wait until the system is stable
15:49:20 test_multidut_pfcwd_basic_with_snappi.te L0574 INFO | Issuing a restart of service swss@0 on the dut ixre-egl-board71
15:50:39 test_multidut_pfcwd_basic_with_snappi.te L0577 INFO | Wait until the system is stable

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…s in multi-asic environment (sonic-net#13483)

The existing PFCWD basic testcases have restart SWSS service testcases.

However, these testcases do not address the multi-asic environment. The pull-request addresses this.

Summary:
Fixes # (issue)
The fix finds out the DUT and interfaces used in the test and based on that selects swss@0 or swss@1 to restart. The fix first verifies if the platform field exists and if yes, is set to 'broadcom-dnx' field. If this is not true, then code executes the default testcase.
@mssonicbld
Copy link
Collaborator Author

Original PR: #13483

@mssonicbld mssonicbld merged commit 895b9f4 into sonic-net:202405 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants