Skip to content

[QoS]SAI_PORT_STAT_IN/OUT_DROPPED_PKTS counters skipped read for dnx platform#13453

Closed
ansrajpu-git wants to merge 5 commits intosonic-net:masterfrom
ansrajpu-git:portCounter_skip
Closed

[QoS]SAI_PORT_STAT_IN/OUT_DROPPED_PKTS counters skipped read for dnx platform#13453
ansrajpu-git wants to merge 5 commits intosonic-net:masterfrom
ansrajpu-git:portCounter_skip

Conversation

@ansrajpu-git
Copy link
Copy Markdown
Contributor

Description of PR

SAI_PORT_STAT_IN/OUT_DROPPED_PKTS is not supported for DNX. #CS00012344046
Added a check in sonic-mgmt qos test for dnx , not to query this counter.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

The sai-thrift_read_port_counters function will update the list for dnx and then read the counters.

What is the motivation for this PR?

How did you do it?

The sai-thrift_read_port_counters function will update the list for dnx and then read the counters.
The test cases are updated accordingly in sai_qos_tests.py

How did you verify/test it?

Executed the qos test and verify the counters are read correctly.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/saitests/py3/sai_qos_tests.py:4313:9: E303 too many blank lines (2)
tests/saitests/py3/sai_qos_tests.py:4941:9: E303 too many blank lines (2)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@ansrajpu-git
Copy link
Copy Markdown
Contributor Author

@vmittal-msft ,Please review

@vmittal-msft
Copy link
Copy Markdown
Contributor

Is following handling the same issue ? then we can mark one as duplicate of other.
#14743 (review)

@vmittal-msft vmittal-msft self-requested a review September 27, 2024 22:10
@ansrajpu-git
Copy link
Copy Markdown
Contributor Author

Is following handling the same issue ? then we can mark one as duplicate of other. #14743 (review)

@vmittal-msft , Closing this PR as its duplicate of PR -#14743 and tested this for t2-chassis.The results looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants