Skip to content

Add optional keyword to onboarding test job#13441

Merged
wangxin merged 1 commit intosonic-net:masterfrom
xwjiang-ms:add_optional_keyword_to_onboarding_job
Jun 26, 2024
Merged

Add optional keyword to onboarding test job#13441
wangxin merged 1 commit intosonic-net:masterfrom
xwjiang-ms:add_optional_keyword_to_onboarding_job

Conversation

@xwjiang-ms
Copy link
Copy Markdown
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Onboarding test jobs are optional test jobs, we are using it in piloting, but some contributors were confused with failed onboarding jobs

How did you do it?

Add an optional keyword to reduce confusion

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@yutongzhang-microsoft
Copy link
Copy Markdown
Contributor

Parameter STOP_ON_FAILURE: "False" and STOP_ON_FAILURE: "False" will promise this checker will always return success, unless the elastic test failed due to some transient issues. So, I think there is no confusion now.

@xwjiang-ms
Copy link
Copy Markdown
Contributor Author

Parameter STOP_ON_FAILURE: "False" and STOP_ON_FAILURE: "False" will promise this checker will always return success, unless the elastic test failed due to some transient issues. So, I think there is no confusion now.

Parameter would not stop testplan, but testplan failure would still cause failure for onboarding jobs, like lock testbed failure, sanity check/testbed issue, so it's needed to add an optional keyword to reduce confusion

@wangxin wangxin merged commit 6ad9228 into sonic-net:master Jun 26, 2024
@xwjiang-ms xwjiang-ms deleted the add_optional_keyword_to_onboarding_job branch June 26, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants