Skip forced mgmt route test if intf is invalid#13438
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Jul 4, 2024
Merged
Skip forced mgmt route test if intf is invalid#13438StormLiangMS merged 1 commit intosonic-net:masterfrom
StormLiangMS merged 1 commit intosonic-net:masterfrom
Conversation
The committers listed above are authorized under a signed CLA. |
dayouliu1
force-pushed
the
skip_test_forced_mgmt_route_on_invalid_intf
branch
from
96edc0a to
99c10b8
Compare
Skip 'test_forced_mgmt_route_add_and_remove_by_mgmt_port_status' in 'route/test_forced_mgmt_route.py' if eth1 does not exist or is being used
dayouliu1
force-pushed
the
skip_test_forced_mgmt_route_on_invalid_intf
branch
from
99c10b8 to
518c544
Compare
Collaborator
|
hi @liuh-80 could you help to take a look? |
Collaborator
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
hi @liuh-80 let's leave the cherry pick approve to the release manager. |
liuh-80
approved these changes
Jul 4, 2024
Collaborator
|
hi @yxieca for cherry pick. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 5, 2024
What is the motivation for this PR? Skip test_forced_mgmt_route_add_and_remove_by_mgmt_port_status in route/test_forced_mgmt_route.py if eth1 does not exist or is being used. This test was failing on Arista platforms when interface eth1 did not exist. How did you do it? Added a check to see if eth1 does not exist, and skips the test if so. How did you verify/test it? Tested on a t0 setup on a Arista-7260
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 5, 2024
What is the motivation for this PR? Skip test_forced_mgmt_route_add_and_remove_by_mgmt_port_status in route/test_forced_mgmt_route.py if eth1 does not exist or is being used. This test was failing on Arista platforms when interface eth1 did not exist. How did you do it? Added a check to see if eth1 does not exist, and skips the test if so. How did you verify/test it? Tested on a t0 setup on a Arista-7260
Collaborator
|
Cherry-pick PR to 202405: #13583 |
Collaborator
|
Cherry-pick PR to 202311: #13584 |
This was referenced Jul 5, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Jul 7, 2024
What is the motivation for this PR? Skip test_forced_mgmt_route_add_and_remove_by_mgmt_port_status in route/test_forced_mgmt_route.py if eth1 does not exist or is being used. This test was failing on Arista platforms when interface eth1 did not exist. How did you do it? Added a check to see if eth1 does not exist, and skips the test if so. How did you verify/test it? Tested on a t0 setup on a Arista-7260
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Jul 7, 2024
What is the motivation for this PR? Skip test_forced_mgmt_route_add_and_remove_by_mgmt_port_status in route/test_forced_mgmt_route.py if eth1 does not exist or is being used. This test was failing on Arista platforms when interface eth1 did not exist. How did you do it? Added a check to see if eth1 does not exist, and skips the test if so. How did you verify/test it? Tested on a t0 setup on a Arista-7260
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 17, 2024
What is the motivation for this PR? Skip test_forced_mgmt_route_add_and_remove_by_mgmt_port_status in route/test_forced_mgmt_route.py if eth1 does not exist or is being used. This test was failing on Arista platforms when interface eth1 did not exist. How did you do it? Added a check to see if eth1 does not exist, and skips the test if so. How did you verify/test it? Tested on a t0 setup on a Arista-7260
Collaborator
|
Cherry-pick PR to 202305: #15022 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 17, 2024
What is the motivation for this PR? Skip test_forced_mgmt_route_add_and_remove_by_mgmt_port_status in route/test_forced_mgmt_route.py if eth1 does not exist or is being used. This test was failing on Arista platforms when interface eth1 did not exist. How did you do it? Added a check to see if eth1 does not exist, and skips the test if so. How did you verify/test it? Tested on a t0 setup on a Arista-7260
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #169
Type of change
Back port request
Approach
What is the motivation for this PR?
Skip
test_forced_mgmt_route_add_and_remove_by_mgmt_port_statusinroute/test_forced_mgmt_route.pyifeth1does not exist or is being used. This test was failing on Arista platforms when interfaceeth1did not exist.How did you do it?
Added a check to see if
eth1does not exist, and skips the test if so.How did you verify/test it?
Tested on a
t0setup on aArista-7260Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation