Wrap test_plan.py in AzureCLI task#13435
Merged
wangxin merged 3 commits intosonic-net:masterfrom Jun 25, 2024
Merged
Conversation
This is the fist step for eliminating client secrets. Purpose of this change is to allow test_plan.py to get access_token via service connection for accessing scheduler. This change wrapped all test_plan.py call in AzureCLI task instead of regular Bash task. The next step is to update test_plan.py to get access_token via service connection. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
lerry-lee
approved these changes
Jun 24, 2024
wangxin
added a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Jun 24, 2024
This is the second part of the work for eliminating client secrets. This change depends on merge of sonic-net#13435. This change updated the test_plan.py to get access token by az cli. For the az cli command to work, the task calling test_plan.py must be wrapped in an AzureCLI azure pipeline task. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
8 tasks
wangxin
added a commit
that referenced
this pull request
Jul 8, 2024
What is the motivation for this PR? This is the second part of the work for eliminating client secrets. This change depends on merge of #13435. How did you do it? This change updated the test_plan.py to get access token by az cli. For the az cli command to work, the task calling test_plan.py must be wrapped in an AzureCLI azure pipeline task. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 10, 2024
What is the motivation for this PR? This is the second part of the work for eliminating client secrets. This change depends on merge of sonic-net#13435. How did you do it? This change updated the test_plan.py to get access token by az cli. For the az cli command to work, the task calling test_plan.py must be wrapped in an AzureCLI azure pipeline task. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
8 tasks
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? This is the second part of the work for eliminating client secrets. This change depends on merge of sonic-net#13435. How did you do it? This change updated the test_plan.py to get access token by az cli. For the az cli command to work, the task calling test_plan.py must be wrapped in an AzureCLI azure pipeline task. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
This is the fist step for eliminating client secrets. Purpose of this change is to allow test_plan.py to get access_token via service connection for accessing scheduler.
How did you do it?
This change wrapped all test_plan.py call in AzureCLI task instead of regular Bash task.
The next step is to update test_plan.py to get access_token via service connection.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation