[action] [PR:13118] Fix route/test_forced_mgmt_route.py#13238
Merged
mssonicbld merged 1 commit intosonic-net:202311from Jun 12, 2024
Merged
[action] [PR:13118] Fix route/test_forced_mgmt_route.py#13238mssonicbld merged 1 commit intosonic-net:202311from
mssonicbld merged 1 commit intosonic-net:202311from
Conversation
What is the motivation for this PR? Test is tampering the running config of the duthost and leaving the config in this state. This is causing failures during teardown core_dump_and_config_check is failing during config_db_check. Also seeing loganalyzer failures with symptom similar to ERR syncd#syncd: [none] SAI_API_UNSPECIFIED:sai_api_query:449 Invalid sai_api_t 50 passed to sai_api_query ... (mostly due to config changes) How did you do it? Perform "config_reload" with the backup config as part of fixture teardown (backup_restore_config). How did you verify/test it? Test is passing consistently with the fix (verified on Arista-7260CX3-C64), verified on 202305 and 202311 branches.
8 tasks
Collaborator
Author
|
Original PR: #13118 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix route/test_forced_mgmt_route.py failures during teardown
Fixes # aristanetworks/sonic-qual.msft#113
Type of change
Back port request
Approach
What is the motivation for this PR?
Test is tampering the running config of the duthost and leaving the config in this state. This is causing failures during teardown
core_dump_and_config_checkis failing duringconfig_db_check.Also seeing loganalyzer failures with symptom similar to
ERR syncd#syncd: [none] SAI_API_UNSPECIFIED:sai_api_query:449 Invalid sai_api_t 50 passed to sai_api_query ...(mostly due to config changes)How did you do it?
Perform "config_reload" with the backup config as part of fixture teardown (
backup_restore_config).How did you verify/test it?
Test is passing consistently with the fix (verified on Arista-7260CX3-C64), verified on 202305 and 202311 branches.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation