Add TH5 ASIC type for QoS Tests#13230
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Jun 13, 2024
ccroy-arista:add-th5-to-asic-type-list-for-qos
Merged
Add TH5 ASIC type for QoS Tests#13230StormLiangMS merged 1 commit intosonic-net:masterfrom ccroy-arista:add-th5-to-asic-type-list-for-qos
StormLiangMS merged 1 commit intosonic-net:masterfrom
ccroy-arista:add-th5-to-asic-type-list-for-qos
Conversation
See aristanetworks/sonic-qual.msft/issues/137 (ASIC type is incorrectly identified as jr2). In conjunction with the addition of the Quicksilver HW SKUs (occurring in a separate pull request) the TH5 ASIC type is being added to the qos base test file here so it can be properly identified during testing, such as in the case of test_qos_sai.py.
Pterosaur
approved these changes
Jun 13, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 13, 2024
See aristanetworks/sonic-qual.msft/issues/137 (ASIC type is incorrectly identified as jr2). In conjunction with the addition of the Quicksilver HW SKUs (occurring in a separate pull request) the TH5 ASIC type is being added to the qos base test file here so it can be properly identified during testing, such as in the case of test_qos_sai.py.
Collaborator
|
Cherry-pick PR to 202311: #13261 |
8 tasks
Collaborator
|
hi @bingwang-ms for 202405 cherry pick. |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 13, 2024
See aristanetworks/sonic-qual.msft/issues/137 (ASIC type is incorrectly identified as jr2). In conjunction with the addition of the Quicksilver HW SKUs (occurring in a separate pull request) the TH5 ASIC type is being added to the qos base test file here so it can be properly identified during testing, such as in the case of test_qos_sai.py.
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
Contributor
Author
|
Awaiting cherry-pick to 202405. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 18, 2024
See aristanetworks/sonic-qual.msft/issues/137 (ASIC type is incorrectly identified as jr2). In conjunction with the addition of the Quicksilver HW SKUs (occurring in a separate pull request) the TH5 ASIC type is being added to the qos base test file here so it can be properly identified during testing, such as in the case of test_qos_sai.py.
Collaborator
|
Cherry-pick PR to 202405: #13348 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jun 18, 2024
See aristanetworks/sonic-qual.msft/issues/137 (ASIC type is incorrectly identified as jr2). In conjunction with the addition of the Quicksilver HW SKUs (occurring in a separate pull request) the TH5 ASIC type is being added to the qos base test file here so it can be properly identified during testing, such as in the case of test_qos_sai.py.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TH5 ASIC type is being added to the qos base test file here so it can be properly identified during testing,
such as in the case of test_qos_sai.py.
Summary:
Fixes https://github.com/aristanetworks/sonic-qual.msft/issues/137
Type of change
Back port request
Approach
What is the motivation for this PR?
Proper identification of the TH5 ASIC for qos tests.
How did you verify/test it?
Verified that the error "Cannot identify DUT ASIC type" no longer occurs when running test_qos_sai.py (the test advances beyond this point of failure now).