Skip to content

ipv6_fixture needs to wait for all services to be up#13213

Merged
yejianquan merged 1 commit intosonic-net:masterfrom
sdszhang:ipv6_netstat_error
Jun 11, 2024
Merged

ipv6_fixture needs to wait for all services to be up#13213
yejianquan merged 1 commit intosonic-net:masterfrom
sdszhang:ipv6_netstat_error

Conversation

@sdszhang
Copy link
Copy Markdown
Contributor

Description of PR

Summary:
Fixes MSFT ADO 28332318

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Fix case error with the following error message:
failed on setup with "Failed: <ipv6 address> not appeared in xxx netstat"

On some physical testbed, the snmpd process took around 3 minutes to come up.
Current convert_and_restore_config_db_to_ipv6_only needs to check all process to be up before proceeding with SNMP checking.

How did you do it?

wait_critical_processes() checks for the critical process which includes snmpd.

How did you verify/test it?

Tested it locally.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Copy link
Copy Markdown
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 0251e0b into sonic-net:master Jun 11, 2024
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jun 12, 2024
Description of PR
Summary:
Fixes MSFT ADO 28332318

Approach
What is the motivation for this PR?
Fix case error with the following error message:
 failed on setup with "Failed: <ipv6 address> not appeared in xxx netstat"

On some physical testbed, the snmpd process took around 3 minutes to come up.
Current convert_and_restore_config_db_to_ipv6_only needs to check all process to be up before proceeding with SNMP checking.

How did you do it?
wait_critical_processes() checks for the critical process which includes snmpd.

How did you verify/test it?
Tested it locally.

co-authorized by: jianquanye@microsoft.com
@mssonicbld
Copy link
Copy Markdown
Collaborator

@sdszhang PR conflicts with 202311 branch

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202405: #13237

@mssonicbld
Copy link
Copy Markdown
Collaborator

@sdszhang PR conflicts with 202305 branch

mssonicbld pushed a commit that referenced this pull request Jun 12, 2024
Description of PR
Summary:
Fixes MSFT ADO 28332318

Approach
What is the motivation for this PR?
Fix case error with the following error message:
 failed on setup with "Failed: <ipv6 address> not appeared in xxx netstat"

On some physical testbed, the snmpd process took around 3 minutes to come up.
Current convert_and_restore_config_db_to_ipv6_only needs to check all process to be up before proceeding with SNMP checking.

How did you do it?
wait_critical_processes() checks for the critical process which includes snmpd.

How did you verify/test it?
Tested it locally.

co-authorized by: jianquanye@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants