[action] [PR:12931] Skip iface loopback test if Leaf-fanout switch is running SONiC and Mellanox ASIC #13128
Merged
mssonicbld merged 1 commit intosonic-net:202311from Jun 4, 2024
Conversation
…ellanox ASIC (sonic-net#12931) * Skip iface_loopback_action test if leaf-fanout switch is Mellanox and running SONiC
8 tasks
Collaborator
Author
|
Original PR: #12931 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The test cases in
test_iface_loopback_action.pyis failing consistently on some testbed when the leaf-fanout is Mellanox and running SONiC. This is because the test sends packets with Vlan tag for testing, while TPID is not supported on Mellanox if running SONiC OS.So the test needs to be skipped in the above setup.
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to skip
test_iface_loopback_action.pyif the leaf-fanout is Mellanox and running SONiC.How did you do it?
Add a fixture to check OS and ASIC of leaf-fanout switch.
How did you verify/test it?
The change is verified on a physical testbed.
Any platform specific information?
Mellanox platform specific.
Supported testbed topology if it's a new test case?
Not a new test case.
Documentation