Remove lldp as default service for Chassis

[abdosi]

Why I did:
To fix this sonic-net/sonic-buildimage#19174
On Modular chassis for LC lldp in global scope is not needed.

How I verify:
Manual changes

[abdosi]

@anamehra for viz.

[anamehra]

https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/devices/sonic.py#L43
and line #53 may also need to be fixed. Please check.

[abdosi]

It is not needed here. lldp still applies to Default asic service list

[SuvarnaMeenakshi]

based on this condition, lldp will not be added in DEFAULT_SERVICES for VS supervisor, is that right?
That will be an issue for VS testbed.

[abdosi]

@SuvarnaMeenakshi : updated.

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/common/devices/multi_asic.py:71:121: E501 line too long (121 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[SuvarnaMeenakshi]

do we need this append here?
This will append lldp DEFAULT_SERVICES for linecard module as well.
Just tried this on a Linecard, and I see that this function https://github.com/sonic-net/sonic-mgmt/blob/67a8074b0bd63c456c315e2649208fcdb4f89045/tests/common/devices/sonic.py#L250C5-L250C35 returns "True"

import sonic_platform
import sonic_platform.platform as P
print(P.Platform().get_chassis().is_modular_chassis())
True

[abdosi]

@SuvarnaMeenakshi

Yes . LLDP will be added as Default Service for Supervisor and Fixed Platoforms (else is for Fixed platforms)

For Modular chassis LLDP will not be added to Default Service List which means for LC we will not add as per our requirement.

[abdosi]

Am I missing something?

[SuvarnaMeenakshi]

got it, misunderstood the condition logic here.

[abdosi]

@wangxin : please help with merge of this.

[patrickmacarthur]

Can this be backported to 202405?

[vperumal]

Hi @abdosi , tests are still failing after this change for lldp, It is because lldp is being added as required status check for RP, but looks like this causes it to get added for LCs too

02:46:39 recover.recover L0185 WARNING| Try to recover aaa14-lc0 using method adaptive
02:46:39 recover.adaptive_recover L0169 WARNING| Restoring {'failed': True, 'check_item': 'processes', 'host': 'aaa14-lc0', 'processes_status': {'pmon': {'status': True, 'exited_critical_process': [], 'running_critical_process': []}, 'snmp': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['snmp-subagent', 'snmpd']}, 'database': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['redis']}, 'lldp': {'status': False, 'exited_critical_process': [], 'running_critical_process': []}, 'bgp0': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['bgpcfgd', 'bgpd', 'fpmsyncd', 'staticd', 'zebra']}, 'database0': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['redis']}, 'lldp0': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['lldp-syncd', 'lldpd', 'lldpmgrd']}, 'swss0': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['buffermgrd', 'coppmgrd', 'fabricmgrd', 'fdbsyncd', 'intfmgrd', 'nbrmgrd', 'neighsyncd', 'orchagent', 'portmgrd', 'portsyncd', 'tunnelmgrd', 'vlanmgrd', 'vrfmgrd', 'vxlanmgrd']}, 'syncd0': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['syncd']}, 'teamd0': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['teammgrd', 'teamsyncd', 'tlm_teamd']}, 'macsec0': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['macsecmgrd']}, 'gbsyncd0': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['syncd']}, 'bgp1': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['bgpcfgd', 'bgpd', 'fpmsyncd', 'staticd', 'zebra']}, 'database1': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['redis']}, 'lldp1': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['lldp-syncd', 'lldpd', 'lldpmgrd']}, 'swss1': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['buffermgrd', 'coppmgrd', 'fabricmgrd', 'fdbsyncd', 'intfmgrd', 'nbrmgrd', 'neighsyncd', 'orchagent', 'portmgrd', 'portsyncd', 'tunnelmgrd', 'vlanmgrd', 'vrfmgrd', 'vxlanmgrd']}, 'syncd1': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['syncd']}, 'teamd1': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['teammgrd', 'teamsyncd', 'tlm_teamd']}, 'macsec1': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['macsecmgrd']}, 'gbsyncd1': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['syncd']}, 'bgp2': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['bgpcfgd', 'bgpd', 'fpmsyncd', 'staticd', 'zebra']}, 'database2': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['redis']}, 'lldp2': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['lldp-syncd', 'lldpd', 'lldpmgrd']}, 'swss2': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['buffermgrd', 'coppmgrd', 'fabricmgrd', 'fdbsyncd', 'intfmgrd', 'nbrmgrd', 'neighsyncd', 'orchagent', 'portmgrd', 'portsyncd', 'tunnelmgrd', 'vlanmgrd', 'vrfmgrd', 'vxlanmgrd']}, 'syncd2': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['syncd']}, 'teamd2': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['teammgrd', 'teamsyncd', 'tlm_teamd']}, 'macsec2': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['macsecmgrd']}, 'gbsyncd2': {'status': True, 'exited_critical_process': [], 'running_critical_process': ['syncd']}}, 'services_status': {'pmon': True, 'snmp': True, 'database': True, 'lldp': False, 'bgp0': True, 'database0': True, 'lldp0': True, 'swss0': True, 'syncd0': True, 'teamd0': True, 'macsec0': True, 'gbsyncd0': True, 'bgp1': True, 'database1': True, 'lldp1': True, 'swss1': True, 'syncd1': True, 'teamd1': True, 'macsec1': True, 'gbsyncd1': True, 'bgp2': True, 'database2': True, 'lldp2': True, 'swss2': True, 'syncd2': True, 'teamd2': True, 'macsec2': True, 'gbsyncd2': True}} with proposed action: config_reload, final action: config_reload

[abdosi]

@vperumal :this should be fix via: #13190

[mssonicbld]

Cherry-pick PR to 202405: #13248