Generate warning for NTP issue#13031
Merged
wangxin merged 1 commit intosonic-net:masterfrom May 31, 2024
Merged
Conversation
bingwang-ms
approved these changes
May 29, 2024
Contributor
Author
|
/azpw run azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@ganglyu , please rerun. |
Contributor
Author
|
/azpw run azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
May 31, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 31, 2024
What is the motivation for this PR? Improve GNMI fixture for NTP check. How did you do it? Remove assert, and generate warning instead.
Collaborator
|
Cherry-pick PR to 202305: #13074 |
8 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 31, 2024
What is the motivation for this PR? Improve GNMI fixture for NTP check. How did you do it? Remove assert, and generate warning instead.
Collaborator
|
Cherry-pick PR to 202311: #13075 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
May 31, 2024
What is the motivation for this PR? Improve GNMI fixture for NTP check. How did you do it? Remove assert, and generate warning instead.
mssonicbld
pushed a commit
that referenced
this pull request
May 31, 2024
What is the motivation for this PR? Improve GNMI fixture for NTP check. How did you do it? Remove assert, and generate warning instead.
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Jul 17, 2024
What is the motivation for this PR? Improve GNMI fixture for NTP check. How did you do it? Remove assert, and generate warning instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Improve GNMI fixture for NTP check.
How did you do it?
Remove assert, and generate warning instead.
How did you verify/test it?
Run gnmi end to end test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation