[TACACS] Improve IPv6 TACACS cases to workaround tacacs_plus server crash issue#13026
Merged
yejianquan merged 1 commit intosonic-net:masterfrom May 29, 2024
Merged
Conversation
…s_plus server crash issue
sdszhang
added
Request for 202305 branch
Request for 202311 branch
Issue for 202311
and removed
Issue for 202311
labels
liuh-80
approved these changes
May 29, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 29, 2024
…s_plus server crash issue (sonic-net#13026) Description of PR Summary: Fixes TACACS failures in test_mgmt_ipv6_only module. Approach What is the motivation for this PR? It's observed that tacacs_plus process may crash when receiving ipv6 tacacs requests. Need a way to workaround it. How did you do it? Similar issue in tacacs/test_ro_user has been fixed in sonic-net#12819 Using the similar method to restart tacacs_plus process if it fails. How did you verify/test it? Verified in both virtual testbed and physical testbed. Not seeing tacacs failures anymore. co-authorized by: [email protected]
Collaborator
|
Cherry-pick PR to 202305: #13032 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 29, 2024
…s_plus server crash issue (sonic-net#13026) Description of PR Summary: Fixes TACACS failures in test_mgmt_ipv6_only module. Approach What is the motivation for this PR? It's observed that tacacs_plus process may crash when receiving ipv6 tacacs requests. Need a way to workaround it. How did you do it? Similar issue in tacacs/test_ro_user has been fixed in sonic-net#12819 Using the similar method to restart tacacs_plus process if it fails. How did you verify/test it? Verified in both virtual testbed and physical testbed. Not seeing tacacs failures anymore. co-authorized by: [email protected]
Collaborator
|
Cherry-pick PR to 202311: #13033 |
mssonicbld
pushed a commit
that referenced
this pull request
May 29, 2024
…s_plus server crash issue (#13026) Description of PR Summary: Fixes TACACS failures in test_mgmt_ipv6_only module. Approach What is the motivation for this PR? It's observed that tacacs_plus process may crash when receiving ipv6 tacacs requests. Need a way to workaround it. How did you do it? Similar issue in tacacs/test_ro_user has been fixed in #12819 Using the similar method to restart tacacs_plus process if it fails. How did you verify/test it? Verified in both virtual testbed and physical testbed. Not seeing tacacs failures anymore. co-authorized by: [email protected]
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
yejianquan
pushed a commit
that referenced
this pull request
May 30, 2024
…s_plus server crash issue (#13026) (#13032) Description of PR Summary: Fixes TACACS failures in test_mgmt_ipv6_only module. Approach What is the motivation for this PR? It's observed that tacacs_plus process may crash when receiving ipv6 tacacs requests. Need a way to workaround it. How did you do it? Similar issue in tacacs/test_ro_user has been fixed in #12819 Using the similar method to restart tacacs_plus process if it fails. How did you verify/test it? Verified in both virtual testbed and physical testbed. Not seeing tacacs failures anymore. co-authorized by: [email protected] Co-authored-by: Dashuai Zhang <[email protected]>
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes TACACS failures in test_mgmt_ipv6_only module.
Type of change
Back port request
Approach
What is the motivation for this PR?
It's observed that tacacs_plus process may crash when receiving ipv6 tacacs requests. Need a way to workaround it.
How did you do it?
Similar issue in tacacs/test_ro_user has been fixed in #12819
Using the similar method to restart tacacs_plus process if it fails.
How did you verify/test it?
Verified in both virtual testbed and physical testbed. Not seeing tacacs failures anymore.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation