[action] [PR:12997] Add detailed and meaningful reason for assert failure in test_ssh_limit#13003
Merged
mssonicbld merged 1 commit intosonic-net:202305from May 29, 2024
Merged
Conversation
What is the motivation for this PR? Add useful information about failed reason. How did you do it? Add the message parameter in pytest_assert How did you verify/test it? Run ssh.test_ssh_limit.
8 tasks
Collaborator
Author
|
Original PR: #12997 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Current failure summary is
Failed: Nonefor test_ssh_limit, it doesn't give us useful information about why it fails.Add detailed reason for assert failure in pytest_assert.
Type of change
Back port request
Approach
What is the motivation for this PR?
Add useful information about failed reason.
How did you do it?
Add the message parameter in pytest_assert
How did you verify/test it?
Run ssh.test_ssh_limit.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation