[action] [PR:12883] Set mux mode to manual to disable port toggle in cacl scripts on dualtor testbed#12894
Merged
mssonicbld merged 1 commit intosonic-net:202311from May 20, 2024
Conversation
…tor testbed (sonic-net#12883) Description of PR GCU test_cacl case failed on dualtor testbed randomly. The failed message: failed on teardown with "Failed: iptable rules are not suppose to change after test. diff: ['+ -A DHCP -m mark --mark 0x67008 -j DROP', '+ -A DHCP -m mark --mark 0x67024 -j DROP', '+ -A DHCP -m mark --mark 0x67022 -j DROP', '+ -A DHCP -m mark --mark 0x67018 -j DROP', '+ -A DHCP -m mark --mark 0x67014 -j DROP', '+ -A DHCP -m mark --mark 0x67013 -j DROP', '+ -A DHCP -m mark --mark 0x67010 -j DROP', '+ -A DHCP -m mark --mark 0x67009 -j DROP', '+ -A DHCP -m mark --mark 0x67004 -j DROP', '+ -A DHCP -m mark --mark 0x67007 -j DROP', '+ -A DHCP -m mark --mark 0x67006 -j DROP', '+ -A DHCP -m mark --mark 0x67002 -j DROP', '+ -A DHCP -m mark --mark 0x67001 -j DROP', '+ -A DHCP -m mark --mark 0x67005 -j DROP']" Summary: Fixes # (issue) The failed reason is dualtor oscillation feature is enabled by default in 202311/mater/internal branch. In nightly test environment, it's easy to trigger oscillation between standby and active ports. In this case, before running test case, some ports are active on DUT, but after test case, when do iptables verification, some ports turn to be standby, that causes iptables DHCP rules to change. The consequence is there is diff between original and latest iptables, which will fail the test case in teardown phase. We have to disable oscillation by set mux to manual mode on both TORs. Enhance the change in sonic-net#11878, set mux mode to manual on both TORs to avoid port state change during test.
8 tasks
Collaborator
Author
|
Original PR: #12883 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
GCU test_cacl case failed on dualtor testbed randomly.
The failed message:
failed on teardown with "Failed: iptable rules are not suppose to change after test. diff: ['+ -A DHCP -m mark --mark 0x67008 -j DROP', '+ -A DHCP -m mark --mark 0x67024 -j DROP', '+ -A DHCP -m mark --mark 0x67022 -j DROP', '+ -A DHCP -m mark --mark 0x67018 -j DROP', '+ -A DHCP -m mark --mark 0x67014 -j DROP', '+ -A DHCP -m mark --mark 0x67013 -j DROP', '+ -A DHCP -m mark --mark 0x67010 -j DROP', '+ -A DHCP -m mark --mark 0x67009 -j DROP', '+ -A DHCP -m mark --mark 0x67004 -j DROP', '+ -A DHCP -m mark --mark 0x67007 -j DROP', '+ -A DHCP -m mark --mark 0x67006 -j DROP', '+ -A DHCP -m mark --mark 0x67002 -j DROP', '+ -A DHCP -m mark --mark 0x67001 -j DROP', '+ -A DHCP -m mark --mark 0x67005 -j DROP']"Summary:
Fixes # (issue)
The failed reason is dualtor oscillation feature is enabled by default in 202311/mater/internal branch.
In nightly test environment, it's easy to trigger oscillation between standby and active ports.
In this case, before running test case, some ports are active on DUT, but after test case, when do iptables verification, some ports turn to be standby, that causes iptables DHCP rules to change. The consequence is there is diff between original and latest iptables, which will fail the test case in teardown phase.
We have to disable oscillation by set mux to manual mode on both TORs.
Enhance the change in #11878,
set mux mode to manual on both TORs to avoid port state change during test.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix random failure of GCU test_cacl.py on dualtor testbed
How did you do it?
Change mux mode to manual before test case and set it back to auto after test case.
How did you verify/test it?
run generic_config_updater.test_cacl on dualtor testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation