Skip to content

[action] [PR:11710] [TACACS] Fix TACACS accounting UT issue caused by auditd log rotate.#12823

Merged
mssonicbld merged 1 commit intosonic-net:202305from
mssonicbld:cherry/202305/11710
May 11, 2024
Merged

[action] [PR:11710] [TACACS] Fix TACACS accounting UT issue caused by auditd log rotate.#12823
mssonicbld merged 1 commit intosonic-net:202305from
mssonicbld:cherry/202305/11710

Conversation

@mssonicbld
Copy link
Collaborator

Fix TACACS accounting UT issue caused by auditd log rotate

Description of PR

Fix TACACS accounting UT issue caused by auditd log rotate

Work item tracking
  • Microsoft ADO: 26710599

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Fix TACACS accounting UT issue caused by auditd log rotate.
There are 2 code issue:

  1. when auditd log rotate, some auditd log will missing from output of 'service auditd status'
  2. duthost.command() can only run 1 command, so can't handle piping output to grep

How did you do it?

show auditd log with 'sudo journalctl -u auditd --boot' and run command with duthost.shell() to support grep.

How did you verify/test it?

Pass all UT

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…#11710)

Fix TACACS accounting UT issue caused by auditd log rotate

### Description of PR
Fix TACACS accounting UT issue caused by auditd log rotate

##### Work item tracking
- Microsoft ADO: 26710599

### Type of change

- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [] Test case(new/improvement)

## Approach
#### What is the motivation for this PR?
Fix TACACS accounting UT issue caused by auditd log rotate.
There are 2 code issue:
1. when auditd log rotate, some auditd log will missing from output of 'service auditd status'
1. duthost.command() can only run 1 command, so can't handle piping output to grep

#### How did you do it?
show auditd log with 'sudo journalctl -u auditd --boot' and run command with duthost.shell() to support grep.

#### How did you verify/test it?
Pass all UT
@mssonicbld
Copy link
Collaborator Author

Original PR: #11710

@mssonicbld mssonicbld merged commit e3f0bdf into sonic-net:202305 May 11, 2024
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
… debs (sonic-net#12823)

Ubuntu 22.04 leverages Zstandard compression to dpkg by default.
Debian doesn't support it yet
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892664

Fix sonic-net#12822

Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
… debs (sonic-net#12823)

Ubuntu 22.04 leverages Zstandard compression to dpkg by default.
Debian doesn't support it yet
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892664

Fix sonic-net#12822

Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
… debs (sonic-net#12823)

Ubuntu 22.04 leverages Zstandard compression to dpkg by default.
Debian doesn't support it yet
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892664

Fix sonic-net#12822

Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants