Update the pfcwd test cases according to the new implement of the pfcwd.#12733
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom May 16, 2024
Merged
Update the pfcwd test cases according to the new implement of the pfcwd.#12733liat-grozovik merged 1 commit intosonic-net:masterfrom
liat-grozovik merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
@nhe-NV please handle the conflicts. |
stephenxs
approved these changes
May 8, 2024
After the feature is completed, it criteria to trigger the pfcwd is much more strict than previous on Nvidia platform, So adjust the test case to properly trigger the pfcwd. The solution is to send background traffic during the pfc frame is sent from the fanout.
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
HI @liat-grozovik conflict fixed, and tested |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
roy-sror
approved these changes
May 12, 2024
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@neethajohn @bingwang-ms would you please review this PR? it is the corresponding test of PFC WD enhancement. thanks. |
liat-grozovik
approved these changes
May 16, 2024
9 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 23, 2024
…wd. (sonic-net#12733) Update the pfcwd test cases according to the new implement of the pfcwd After the feature is completed, it criteria to trigger the pfcwd is much more strict than previous on Nvidia platform, So adjust the test case to properly trigger the pfcwd. The solution is to send background traffic during the pfc frame is sent from the fanout.
Collaborator
|
Cherry-pick PR to 202311: #13778 |
Merged
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 23, 2024
…wd. (#12733) Update the pfcwd test cases according to the new implement of the pfcwd After the feature is completed, it criteria to trigger the pfcwd is much more strict than previous on Nvidia platform, So adjust the test case to properly trigger the pfcwd. The solution is to send background traffic during the pfc frame is sent from the fanout.
8 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Aug 1, 2024
What is the motivation for this PR? The test case failed in nightly build. Should be related to the PR #12733, which decrease the detect sleep time for test_pfcwd_timer_accuracy How did you do it? Enlarge the detect sleep time How did you verify/test it? Run original case
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 1, 2024
What is the motivation for this PR? The test case failed in nightly build. Should be related to the PR sonic-net#12733, which decrease the detect sleep time for test_pfcwd_timer_accuracy How did you do it? Enlarge the detect sleep time How did you verify/test it? Run original case
8 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 1, 2024
What is the motivation for this PR? The test case failed in nightly build. Should be related to the PR sonic-net#12733, which decrease the detect sleep time for test_pfcwd_timer_accuracy How did you do it? Enlarge the detect sleep time How did you verify/test it? Run original case
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 1, 2024
What is the motivation for this PR? The test case failed in nightly build. Should be related to the PR #12733, which decrease the detect sleep time for test_pfcwd_timer_accuracy How did you do it? Enlarge the detect sleep time How did you verify/test it? Run original case
mssonicbld
pushed a commit
that referenced
this pull request
Aug 1, 2024
What is the motivation for this PR? The test case failed in nightly build. Should be related to the PR #12733, which decrease the detect sleep time for test_pfcwd_timer_accuracy How did you do it? Enlarge the detect sleep time How did you verify/test it? Run original case
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? The test case failed in nightly build. Should be related to the PR sonic-net#12733, which decrease the detect sleep time for test_pfcwd_timer_accuracy How did you do it? Enlarge the detect sleep time How did you verify/test it? Run original case
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
What is the motivation for this PR? The test case failed in nightly build. Should be related to the PR sonic-net#12733, which decrease the detect sleep time for test_pfcwd_timer_accuracy How did you do it? Enlarge the detect sleep time How did you verify/test it? Run original case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the pfcwd test cases according to the new implement of the pfcwd
After the feature is completed, it criteria to trigger the pfcwd is much more strict than previous on Nvidia platform, So adjust the test case to properly trigger the pfcwd. The solution is to send background traffic during the pfc frame is sent from the fanout.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To make the pfcwd test case could pass after the new implement of the pfcwd.
How did you do it?
Add the logic of sending the background traffic to make the test case could pass after the new implement of the pfcwd
How did you verify/test it?
All pfcwd test case could pass
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation