-
Notifications
You must be signed in to change notification settings - Fork 1k
Add module platform_tests/test_kdump.py into PR test
#12732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wangxin
merged 8 commits into
sonic-net:master
from
yutongzhang-microsoft:yutongzhang/add_test_kdump
May 13, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d746e7c
Modify pdu controller
yutongzhang-microsoft 0dbab3b
fix KeyError
yutongzhang-microsoft 1e76b4c
Remove unnecessary code
yutongzhang-microsoft e402887
modify
yutongzhang-microsoft 887854d
modify
yutongzhang-microsoft 79c1333
Add comment
yutongzhang-microsoft 5a5d149
Merge branch 'master' into yutongzhang/add_test_kdump
yutongzhang-microsoft 0cb8aed
Add comment
yutongzhang-microsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if hostnames are not there for device_pdu_links and device_pdu_info, why are we changing it them to empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just saw your previous comments.
could you add a comment here to explain why you change to return empty hostnames if they are not found in csv files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change aims to adapt to the kvm testbed. For kvm, conn_graph_facts is None, so we use function
getto avoid KeyError and give it default value{}if the key doesn't exist.I think here we don't
return empty hostnames, the pdu info is empty here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, could you add this to code as comment as well? It'll help a lot
unfortunately, for most DUTs, we will get None because there is no key pdu_host under most of the hosts. And although we can get the pdu hosts list of a DUT from inventory, we can not get the hwsku and os of pdu host from inventory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added.