Skip to content

[Draft] debug test_plan.py#12645

Closed
lerry-lee wants to merge 5 commits intosonic-net:masterfrom
lerry-lee:chunangli/debug_test_plan
Closed

[Draft] debug test_plan.py#12645
lerry-lee wants to merge 5 commits intosonic-net:masterfrom
lerry-lee:chunangli/debug_test_plan

Conversation

@lerry-lee
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

.azure-pipelines/test_plan.py:892:17: E122 continuation line missing indentation or outdented
.azure-pipelines/test_plan.py:893:17: E122 continuation line missing indentation or outdented
.azure-pipelines/test_plan.py:894:17: E122 continuation line missing indentation or outdented
.azure-pipelines/test_plan.py:895:17: E122 continuation line missing indentation or outdented
.azure-pipelines/test_plan.py:896:17: E122 continuation line missing indentation or outdented
.azure-pipelines/test_plan.py:897:13: E122 continuation line missing indentation or outdented

flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
@lerry-lee lerry-lee force-pushed the chunangli/debug_test_plan branch from 2c59179 to 56a7f53 Compare September 2, 2024 06:16
@lerry-lee lerry-lee changed the title [Draft] Debug custom mark 'device_type', by default run on both physical and vs devices [Draft] debug test_plan.py Sep 2, 2024
Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
@lerry-lee lerry-lee closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants