Skip to content

[201811][dhcp_relay] Add link state change tests#1264

Merged
jleveque merged 1 commit intosonic-net:201811from
jleveque:enhance_dhcp_relay_test_201811
Dec 9, 2019
Merged

[201811][dhcp_relay] Add link state change tests#1264
jleveque merged 1 commit intosonic-net:201811from
jleveque:enhance_dhcp_relay_test_201811

Conversation

@jleveque
Copy link
Copy Markdown
Contributor

@jleveque jleveque commented Dec 7, 2019

Summary:

Enhance DHCP relay test to ensure relay agent is robust enough to handle link state changes and starting up when configured links are down. This test validates the bug fix in sonic-net/sonic-buildimage#3852 and should help prevent regressions.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

After the standard DHCP relay test, run two more tests, as follows:

  1. With the relay healthy, flap the uplinks and test again
  2. Stop relay, shut down links, start relay, bring up links, test again

How did you verify/test it?

Tested on a DUT with and without the patch mentioned above. Without the patch, the test fails; with the patch, the test succeeds.

@jleveque jleveque requested a review from lguohan December 7, 2019 22:51
@jleveque jleveque self-assigned this Dec 7, 2019
@jleveque jleveque merged commit 47d98fe into sonic-net:201811 Dec 9, 2019
@jleveque jleveque deleted the enhance_dhcp_relay_test_201811 branch December 9, 2019 19:04
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…tically (sonic-net#15724)

#### Why I did it
src/sonic-sairedis
```
* d1850e2 - (HEAD -> 202211, origin/202211) [CI]: Fix pipeline issue caused by urllib3 v2. (sonic-net#1264) (13 hours ago) [Nazarii Hnydyn]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants