Skip to content

[202311] Fix issues due to password rotation#12355

Merged
wangxin merged 2 commits intosonic-net:202311from
yutongzhang-microsoft:yutongzhang/fix_ssh_202311
Apr 9, 2024
Merged

[202311] Fix issues due to password rotation#12355
wangxin merged 2 commits intosonic-net:202311from
yutongzhang-microsoft:yutongzhang/fix_ssh_202311

Conversation

@yutongzhang-microsoft
Copy link
Contributor

Description of PR

This PR is a combination of #12253, #12255 and #12264

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

This PR is a combination of #12253, #12255 and #12264

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/ssh/test_ssh_limit.py:3:1: F401 'paramiko' imported but unused

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@wangxin wangxin merged commit 2d4e75e into sonic-net:202311 Apr 9, 2024
@yutongzhang-microsoft yutongzhang-microsoft deleted the yutongzhang/fix_ssh_202311 branch April 10, 2024 01:56
@yutongzhang-microsoft yutongzhang-microsoft restored the yutongzhang/fix_ssh_202311 branch April 16, 2024 02:04
@yutongzhang-microsoft yutongzhang-microsoft deleted the yutongzhang/fix_ssh_202311 branch April 16, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants