T2-VOQ-VS: Add command to loganalyzer ignore#12345
Merged
judyjoseph merged 2 commits intosonic-net:masterfrom Apr 9, 2024
Merged
T2-VOQ-VS: Add command to loganalyzer ignore#12345judyjoseph merged 2 commits intosonic-net:masterfrom
judyjoseph merged 2 commits intosonic-net:masterfrom
Conversation
saiarcot895
approved these changes
Apr 9, 2024
Contributor
Author
|
@judyjoseph , could you please help review/merge this PR? |
judyjoseph
approved these changes
Apr 9, 2024
11 tasks
Contributor
|
This isn't actually matching the syslog message because there's a space before |
Contributor
Author
yes.. realized this.. will fix it today.. thanks for pointing out. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
As part of T2-VS Support changes(sonic-net/sonic-buildimage#18512), sonic_platform package will be available now on VS platforms.
sfputil script was getting exited earlier due to module not found. But now, the module will be found, and next it invokes load_platform_chassis(). For non-chassis VS platforms, the metadata file will not be present, and hence it throws an exception with a syslog.
ERR sfputil: Failed to instantiate Chassis due to FileNotFoundError('Metadata file /etc/sonic/vs_chassis_metadata.json not found')
The sonic-mgmt tests on VS which invoke sfputil commands are failing with loganalyzer caching this message.
Fix: Adding the above to loganalyzer ignore messages.
Type of change
Back port request
Approach
What is the motivation for this PR?
As part of T2-VS Support changes, sonic_platform package will be available now on VS platforms.
sfputil script was getting exited earlier due to module not found. But now, the module will be found, and next it invokes load_platform_chassis(). For non-chassis VS platforms, the metadata file will not be present, and hence it throws an exception with a syslog.
ERR sfputil: Failed to instantiate Chassis due to FileNotFoundError('Metadata file /etc/sonic/vs_chassis_metadata.json not found')
How did you do it?
Added the above to loganalyzer ignore messages.
How did you verify/test it?
Any platform specific information?
None
Supported testbed topology if it's a new test case?
None
Documentation