Skip to content

T2-VOQ-VS: Add command to loganalyzer ignore#12345

Merged
judyjoseph merged 2 commits intosonic-net:masterfrom
deepak-singhal0408:deepsinghal/add_command_loganalyzer_ignore
Apr 9, 2024
Merged

T2-VOQ-VS: Add command to loganalyzer ignore#12345
judyjoseph merged 2 commits intosonic-net:masterfrom
deepak-singhal0408:deepsinghal/add_command_loganalyzer_ignore

Conversation

@deepak-singhal0408
Copy link
Copy Markdown
Contributor

Description of PR

Summary:
As part of T2-VS Support changes(sonic-net/sonic-buildimage#18512), sonic_platform package will be available now on VS platforms.
sfputil script was getting exited earlier due to module not found. But now, the module will be found, and next it invokes load_platform_chassis(). For non-chassis VS platforms, the metadata file will not be present, and hence it throws an exception with a syslog.
ERR sfputil: Failed to instantiate Chassis due to FileNotFoundError('Metadata file /etc/sonic/vs_chassis_metadata.json not found')

The sonic-mgmt tests on VS which invoke sfputil commands are failing with loganalyzer caching this message.

Fix: Adding the above to loganalyzer ignore messages.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

As part of T2-VS Support changes, sonic_platform package will be available now on VS platforms.
sfputil script was getting exited earlier due to module not found. But now, the module will be found, and next it invokes load_platform_chassis(). For non-chassis VS platforms, the metadata file will not be present, and hence it throws an exception with a syslog.
ERR sfputil: Failed to instantiate Chassis due to FileNotFoundError('Metadata file /etc/sonic/vs_chassis_metadata.json not found')

How did you do it?

Added the above to loganalyzer ignore messages.

How did you verify/test it?

Any platform specific information?

None

Supported testbed topology if it's a new test case?

None

Documentation

@deepak-singhal0408 deepak-singhal0408 changed the title Add command to loganalyzer ignore T2-VOQ-VS: Add command to loganalyzer ignore Apr 8, 2024
@deepak-singhal0408 deepak-singhal0408 self-assigned this Apr 8, 2024
@deepak-singhal0408
Copy link
Copy Markdown
Contributor Author

@judyjoseph , could you please help review/merge this PR?

@judyjoseph judyjoseph merged commit f013d7a into sonic-net:master Apr 9, 2024
@saiarcot895
Copy link
Copy Markdown
Contributor

This isn't actually matching the syslog message because there's a space before Metadata here, but that space isn't in the actual log message.

@deepak-singhal0408
Copy link
Copy Markdown
Contributor Author

This isn't actually matching the syslog message because there's a space before Metadata here, but that space isn't in the actual log message.

yes.. realized this.. will fix it today.. thanks for pointing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants