Added dscp mode for decap test for marvell#1228
Closed
rajneeshaec wants to merge 3 commits intosonic-net:masterfrom
Closed
Added dscp mode for decap test for marvell#1228rajneeshaec wants to merge 3 commits intosonic-net:masterfrom
rajneeshaec wants to merge 3 commits intosonic-net:masterfrom
Conversation
prsunny
reviewed
Nov 22, 2019
ansible/roles/test/tasks/decap.yml
Outdated
| dscp_mode: pipe | ||
| ecn_mode: copy_from_outer | ||
| when: | ||
| - sonic_hwsku in marvell_hwskus |
Contributor
There was a problem hiding this comment.
can you add this as an "or" check to line 11 instead of defining the same thing again. You can update the comment.
Contributor
Author
There was a problem hiding this comment.
Hi prsunny
I have modified the changes according to review comment, Could you please review this
Thanks
Rajneesh
Contributor
Author
There was a problem hiding this comment.
I have already removed these lines
is it still showing ?
Thanks
Rajneesh
Contributor
Author
|
Hi @prsunny Thanks |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Added dscp mode for decap test for marvell
Type of change
Approach
How did you do it?
Added dscp mode for marvell in decap.yml file
How did you verify/test it?
tested in local testbed
Any platform specific information?
N/A