Skip to content

Fix issues in test_ssh_ciphers.py caused by password rotation #12264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yejianquan merged 2 commits into from
Apr 3, 2024
Merged

Fix issues in test_ssh_ciphers.py caused by password rotation #12264

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
114189c
Fix test_ssh_ciphers.py
yutongzhang-microsoft Apr 2, 2024
222e812
Merge remote-tracking branch 'origin/master'
yutongzhang-microsoft Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions tests/ssh/test_ssh_ciphers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ def connect_with_specified_ciphers(duthosts, rand_one_dut_hostname, specified_ci
dutuser, dutpass = creds['sonicadmin_user'], creds['sonicadmin_password']
sonic_admin_alt_password = duthost.host.options['variable_manager']._hostvars[duthost.hostname].get(
"ansible_altpassword")
sonic_admin_alt_passwords = creds["ansible_altpasswords"]
dut_passwords = [dutpass, sonic_admin_alt_password] + sonic_admin_alt_passwords
dutip = duthost.mgmt_ip

if typename == "enc":
Expand All @@ -31,29 +33,23 @@ def connect_with_specified_ciphers(duthosts, rand_one_dut_hostname, specified_ci
ssh_cmd = "ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no {} {}@{}".format(
ssh_cipher_option, dutuser, dutip)

try:
connect = pexpect.spawn(ssh_cmd)
connect.expect('.*[Pp]assword:')
connect.sendline(dutpass)

i = connect.expect(
'{}@{}:'.format(dutuser, duthost.hostname), timeout=10)
pytest_assert(i == 0, "Failed to connect")
except Exception:
for dutpass in dut_passwords:
try:
connect = pexpect.spawn(ssh_cmd)
connect.expect('.*[Pp]assword:')
connect.sendline(sonic_admin_alt_password)
connect.sendline(dutpass)

i = connect.expect(
'{}@{}:'.format(dutuser, duthost.hostname), timeout=10)
pytest_assert(i == 0, "Failed to connect")
except pexpect.exceptions.EOF:
pytest.fail("EOF reached")
except pexpect.exceptions.TIMEOUT:
pytest.fail("Timeout reached")
return
except Exception as e:
pytest.fail("Cannot connect to DUT host via SSH: {}".format(e))
output = connect.before.decode()
if "Permission denied" in output:
continue
else:
pytest.fail(e)
pytest.fail("Cannot connect to DUT host via SSH")


def test_ssh_protocol_version(duthosts, rand_one_dut_hostname):
Expand Down