Skip to content

[test_sfp.py]Ignore the error logs for known issue in SFP reset & LPM test#1205

Merged
liat-grozovik merged 2 commits intosonic-net:201811from
stephenxs:fix-sfp-eeprom-error
Nov 19, 2019
Merged

[test_sfp.py]Ignore the error logs for known issue in SFP reset & LPM test#1205
liat-grozovik merged 2 commits intosonic-net:201811from
stephenxs:fix-sfp-eeprom-error

Conversation

@stephenxs
Copy link
Contributor

@stephenxs stephenxs commented Nov 12, 2019

Description of PR

Ignore the error logs of "Eeprom query failed" in reset sfp & lpm test.
It is introduced temporarily as a workaround for the known issue [test_sfp.py]Ignore the error logs for known issue in SFP reset & LPM test #1205 and will be removed after the issue is resolved.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

Fix the issue that error logs "Eeprom query failed" found during test_sfp running by ignoring the log.
During the test, the sfp modules can be reset or set to lpm mode, which causes the sfp module inaccessible temporary. When the xcvrd receives the "plugin" event it tries to access the module but it takes seconds for the sfp module to be accessible, which causes that log.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@liat-grozovik
Copy link
Collaborator

This is a WA till we get to the button of the fix. If you already raised an issue please refer to it so once it is fixed the ignore log will be removed.

@stephenxs stephenxs marked this pull request as ready for review November 12, 2019 15:45
@stephenxs
Copy link
Contributor Author

This is a WA till we get to the button of the fix. If you already raised an issue please refer to it so once it is fixed the ignore log will be removed.

Done.

@stephenxs stephenxs changed the title [test_sfp.py]Ignore the error logs for known issue in reset sfp & lpm test [test_sfp.py]Ignore the error logs for known issue in SFP reset & LPM test Nov 18, 2019
@liat-grozovik liat-grozovik merged commit a7f4a4e into sonic-net:201811 Nov 19, 2019
@stephenxs stephenxs deleted the fix-sfp-eeprom-error branch November 19, 2019 16:26
lguohan pushed a commit that referenced this pull request Feb 11, 2020
… test (#1205) (#1379)

* [test_sfp.py]Fix the issue that error logs of reading eeprom found during test_sfp running by ignore the log
The log is expected.

* only ignore the error message on Mellanox platform
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Why I did it
cf9a66b - Fix issue: bulk counter feature is disabled ([Broadcom]: Update Broadcom SDK/SAI package sonic-net#1205) (4 hours ago) [Lior Avramov]
8b1583b - [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd ([Makefile]: variable ENABLE_SYNCD_RPC is always empty string sonic-net#1201) (4 hours ago) [Andriy Yurkiv]
50d8e21 - [syncd]: Enable port bulk API ([platform] Accton AS7712-32X. Update for sensors and sfputil. sonic-net#1197) (4 hours ago) [Nazarii Hnydyn]
a72438a - Use new value of STATE_DB FAST_REBOOT entry ([device/accton]: Update Accton-AS5712_54X sonic-net#1196) (4 hours ago) [Aryeh Feigin]
d78ce86 - validation support for SAI_ATTR_VALUE_TYPE_JSON ([installer] FIX. ONIE installer error issue: sonic-net#1152) (4 hours ago) [svshah-intel]
How I did it
How to verify it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants