[test_sfp.py]Ignore the error logs for known issue in SFP reset & LPM test#1205
Merged
liat-grozovik merged 2 commits intosonic-net:201811from Nov 19, 2019
stephenxs:fix-sfp-eeprom-error
Merged
[test_sfp.py]Ignore the error logs for known issue in SFP reset & LPM test#1205liat-grozovik merged 2 commits intosonic-net:201811from stephenxs:fix-sfp-eeprom-error
liat-grozovik merged 2 commits intosonic-net:201811from
stephenxs:fix-sfp-eeprom-error
Conversation
added 2 commits
October 31, 2019 08:46
…ring test_sfp running by ignore the log The log is expected.
Collaborator
|
This is a WA till we get to the button of the fix. If you already raised an issue please refer to it so once it is fixed the ignore log will be removed. |
Contributor
Author
Done. |
keboliu
approved these changes
Nov 15, 2019
liat-grozovik
approved these changes
Nov 19, 2019
1 task
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Why I did it cf9a66b - Fix issue: bulk counter feature is disabled ([Broadcom]: Update Broadcom SDK/SAI package sonic-net#1205) (4 hours ago) [Lior Avramov] 8b1583b - [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd ([Makefile]: variable ENABLE_SYNCD_RPC is always empty string sonic-net#1201) (4 hours ago) [Andriy Yurkiv] 50d8e21 - [syncd]: Enable port bulk API ([platform] Accton AS7712-32X. Update for sensors and sfputil. sonic-net#1197) (4 hours ago) [Nazarii Hnydyn] a72438a - Use new value of STATE_DB FAST_REBOOT entry ([device/accton]: Update Accton-AS5712_54X sonic-net#1196) (4 hours ago) [Aryeh Feigin] d78ce86 - validation support for SAI_ATTR_VALUE_TYPE_JSON ([installer] FIX. ONIE installer error issue: sonic-net#1152) (4 hours ago) [svshah-intel] How I did it How to verify it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Ignore the error logs of "Eeprom query failed" in reset sfp & lpm test.
It is introduced temporarily as a workaround for the known issue [test_sfp.py]Ignore the error logs for known issue in SFP reset & LPM test #1205 and will be removed after the issue is resolved.
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
Fix the issue that error logs "Eeprom query failed" found during test_sfp running by ignoring the log.
During the test, the sfp modules can be reset or set to lpm mode, which causes the sfp module inaccessible temporary. When the xcvrd receives the "plugin" event it tries to access the module but it takes seconds for the sfp module to be accessible, which causes that log.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation