[platform][cli] PSU Status Tests: Permit Daemons Some Time to enter RUNNING State#12047
Merged
prgeor merged 1 commit intosonic-net:masterfrom Apr 17, 2024
ccroy-arista:psustatus-daemon-wait
Merged
[platform][cli] PSU Status Tests: Permit Daemons Some Time to enter RUNNING State#12047prgeor merged 1 commit intosonic-net:masterfrom ccroy-arista:psustatus-daemon-wait
prgeor merged 1 commit intosonic-net:masterfrom
ccroy-arista:psustatus-daemon-wait
Conversation
…t loop to provide some flexibility in the amount of time it takes for the daemons to go from STARTING state to RUNNING.
The committers listed above are authorized under a signed CLA. |
Collaborator
|
@prgeor could you help to review? |
prgeor
approved these changes
Apr 17, 2024
Collaborator
|
hi @ccroy-arista could you help to test with 202311 branch so we can do the cherry pick to avoid regression. |
Contributor
Author
|
Hi @StormLiangMS, the changes were tested against 202311 at the time (March 15); 10 iterations were run to establish confidence (all passed). |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Apr 19, 2024
…t loop to provide some flexibility in the amount of time it takes for the daemons to go from STARTING state to RUNNING. (sonic-net#12047)
Collaborator
|
Cherry-pick PR to 202311: #12513 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Apr 19, 2024
…t loop to provide some flexibility in the amount of time it takes for the daemons to go from STARTING state to RUNNING. (#12047)
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
This patch adds a 60-second window to the psustatus tests to allow time for the relevant daemons to reach the RUNNING state, should they be found in the STARTING state when the daemon status check occurs.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Encountered an instance where the psustatus tests failed because the pmon daemon status check caught the applicable daemons in the STARTING state as opposed to the RUNNING state. This was seen one time; despite a few dozen attempts, have not been able to recreate the issue. This change will help guard against such potential race conditions.
How did you do it?
Added a 60 second wait (5 second interval, 0 delay) on
check_pmon_daemon_statusin each of the psustatus tests.How did you verify/test it?
Ran the tests with the fixes applied and they passed.