Skip to content

Add new tests for Link Local SIP/DIP#11940

Closed
slutati1536 wants to merge 2 commits intosonic-net:masterfrom
slutati1536:new_link_local_tests
Closed

Add new tests for Link Local SIP/DIP#11940
slutati1536 wants to merge 2 commits intosonic-net:masterfrom
slutati1536:new_link_local_tests

Conversation

@slutati1536
Copy link
Contributor

Description of PR

Test Plan PR: #11712

Summary:
The purpose of the tests is to verify that traffic with link-local source/destination IP is received and routed/switched by the dut.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

To verify that MSFT hwsku will allow packets with link-local source/destination IP to be forwarded by the dut. This capability is only supported on systems that have SAI_NOT_DROP_SIP_DIP_LINK_LOCAL=1 in sai.profile

How did you do it?

Revised the existing IP test and used common functionality, also reviewed the test plan, and implemented tests accordingly.

How did you verify/test it?

run it on all topologies to check the stability

Any platform-specific information?

systems that have SAI_NOT_DROP_SIP_DIP_LINK_LOCAL=1 in sai.profile

Supported testbed topology if it's a new test case?

any

Signed-off-by: Sharon Lutati <slutati@nvidia.com>
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/ip/link_local/test_link_local_ip.py:120:121: E501 line too long (139 > 120 characters)
tests/ip/link_local/test_link_local_ip.py:121:121: E501 line too long (121 > 120 characters)
tests/ip/link_local/test_link_local_ip.py:126:121: E501 line too long (122 > 120 characters)
tests/ip/link_local/test_link_local_ip.py:129:121: E501 line too long (122 > 120 characters)
tests/ip/link_local/test_link_local_ip.py:176:121: E501 line too long (127 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@bingwang-ms
Copy link
Collaborator

Closing this PR as new PR is opened to fix the issue.

@bingwang-ms bingwang-ms closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants