[action] [PR:11779] [bgp]: Don't flush link-local addr during teardown#11887
Merged
mssonicbld merged 1 commit intosonic-net:202305from Mar 5, 2024
Merged
[action] [PR:11779] [bgp]: Don't flush link-local addr during teardown#11887mssonicbld merged 1 commit intosonic-net:202305from
mssonicbld merged 1 commit intosonic-net:202305from
Conversation
What is the motivation for this PR? During the teardown for bgp/test_bgp_dual_asn.py::test_bgp_dual_asn_v4, the PTF interface used for the test is flushed of all IPv4 and IPv6 addresses, including the IPv6 link local address. As a result, NDP and other IPv6 functionality is broken for the flushed interface. How did you do it? Specify 'global' scope when flushing the PTF interface to avoid removing IPv6 link local addresses. How did you verify/test it? Run the test, verify that all PTF addresses still have an IPv6 link local address after the test is finished.
8 tasks
Collaborator
Author
|
Original PR: #11779 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
During the teardown for
bgp/test_bgp_dual_asn.py::test_bgp_dual_asn_v4, the PTF interface used for the test is flushed of all IPv4 and IPv6 addresses, including the IPv6 link local address. As a result, NDP and other IPv6 functionality is broken for the flushed interface.How did you do it?
Specify 'global' scope when flushing the PTF interface to avoid removing IPv6 link local addresses.
How did you verify/test it?
Run the test, verify that all PTF addresses still have an IPv6 link local address after the test is finished.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation