set get() default value to dict in order to avoid keys() error#11684
Merged
prgeor merged 1 commit intosonic-net:masterfrom Mar 1, 2024
Merged
set get() default value to dict in order to avoid keys() error#11684prgeor merged 1 commit intosonic-net:masterfrom
prgeor merged 1 commit intosonic-net:masterfrom
Conversation
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Change-Id: I62486e8265c0f90791d79dc72a37305c2e93c33b
illia-kotvitskyi
force-pushed
the
fwutil_conftest_dict_fix
branch
from
e8a001b to
4b8d229
Compare
Contributor
Author
|
Hi @prgeor, could you please review this PR? |
Contributor
Author
Kindly reminder |
prgeor
approved these changes
Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I62486e8265c0f90791d79dc72a37305c2e93c33b
Description of PR
Summary:
Fixes
AttributeError: 'list' object has no attribute 'keys'error by replacing.get()default value to be dict instead of list inrandom_componentfwutil fixtureType of change
Back port request
Approach
What is the motivation for this PR?
Avoid AttributeError when dict has no expected key
How did you do it?
Use dict as default value instead of a list
How did you verify/test it?
Run TC, no error is raised
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation