Skip to content

[DASH] New test cases for dash acl tag#11559

Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom
congh-nvidia:dash_acl_tag
Feb 25, 2024
Merged

[DASH] New test cases for dash acl tag#11559
liat-grozovik merged 1 commit intosonic-net:masterfrom
congh-nvidia:dash_acl_tag

Conversation

@congh-nvidia
Copy link
Copy Markdown
Contributor

Description of PR

Summary:
Add new test cases for dash acl tag feature.
Test plan: https://github.com/sonic-net/sonic-mgmt/blob/master/docs/testplan/dash/Dash-ACL-Tag-test-plan.md

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

Add new test cases for dash acl tag feature

How did you do it?

All new test cases are added to the test_dash_acl.py and dash_acl.py.
For the scale test case, need to do some improvement in the dash acl test infra and dash gnmi utils to allow applying massive configurations through gnmi and shorten the config time.
The improvements are:

  • Separate the gnmi command into multiple commands if it is too long, for there is a limitation in the length of command.
  • Directly copy the updates to ptf instead of to dut. Since we are now using gnmi, no need to copy the config to dut, this will greatly reduce the config time.
  • Tar the update files before copying them to save great time.
    Note:
  • For the scale test case, only test 4096 tags with 1 IP address in each, due to issue [DPU][ACL][scale] The DPU doesn't support the scale of 4k tags with 24k IPs in each sonic-buildimage#17714.

How did you verify/test it?

Run the test cases on DPU testbed, all passed.

Any platform specific information?

Only for dpu.

Supported testbed topology if it's a new test case?

Only for dpu topology.

Documentation

Test plan: https://github.com/sonic-net/sonic-mgmt/blob/master/docs/testplan/dash/Dash-ACL-Tag-test-plan.md

Add new test cases for dash acl tag feature
@liat-grozovik
Copy link
Copy Markdown
Collaborator

@prsunny please assign someone to review

@congh-nvidia congh-nvidia marked this pull request as ready for review February 20, 2024 12:16
@congh-nvidia
Copy link
Copy Markdown
Contributor Author

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@congh-nvidia
Copy link
Copy Markdown
Contributor Author

@nhe-NV @roy-sror please review. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants