[Mellanox pytest] change the way to check default fan speed setting #1153
Closed
keboliu wants to merge 7 commits intosonic-net:masterfrom
keboliu:wa-for-default-fan-speed
Closed
[Mellanox pytest] change the way to check default fan speed setting #1153keboliu wants to merge 7 commits intosonic-net:masterfrom keboliu:wa-for-default-fan-speed
keboliu wants to merge 7 commits intosonic-net:masterfrom
keboliu:wa-for-default-fan-speed
Conversation
merge from upstream
…ry 10s) to waiting for 300s
Contributor
Author
|
still have issue on some testbed, close first. |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…#12974) utilities: * 4b51e41 2022-12-06 | [config] Add check in config interface ip command to block if the interface is portchannel member (sonic-net#2539) (HEAD -> 202205) [Sudharsan Dhamal Gopalarathnam] * e53b32e 2022-12-06 | [generate_dump] [Mellanox] Fix the duplicate dfw dump collection problem by adding symlinks (sonic-net#2536) [Vivek] * 0391221 2022-12-02 | [GCU] Add RemoveCreateOnlyDependency Validator/Generator (sonic-net#2500) [jingwenxie] * e3658e9 2022-04-13 | [scripts/fast-reboot] Shutdown remaining containers through systemd (sonic-net#2133) [Stepan Blyshchak] swss: * 1a4a5d9 2022-12-02 | [ACL] Support ACTION_COUNTER action in custom ACL table type (sonic-net#2550) [bingwang-ms] * 33b0a9e 2022-12-05 | [muxorch] Adding case for maintaining current state (sonic-net#2280) [Nikola Dancejic] sairedis: * b29bb45 2022-12-02 | enable cisco8000 SAI bulk API feature (sonic-net#1153) (HEAD -> 202205) [Keith Lu] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…le head (sonic-net#13353) utilties: * 7fc3fb7 2023-01-06 | [storyteller] add link prober state change to story teller (sonic-net#2585) (HEAD -> 202205, github/202205) [Jing Zhang] * d8202e8 2023-01-12 | [202205] Added a new option in show queue counters command to display voq statistics (sonic-net#2591) [Sambath Kumar Balasubramanian] * 98dde31 2023-01-11 | resolved conflicts (sonic-net#2589) [kannankvs] swss: * 268c3f3 2023-01-11 | Added new attributes for Vnet and Vxlan ecmp configurations. (sonic-net#2584) (HEAD -> 202205, github/202205) [siqbal1986] * 50235b6 2023-01-12 | [routesync] Fix for stale dynamic neighbor (sonic-net#2553) [vganesan-nokia] * ad9d826 2023-01-12 | [202205][voq] Add voq counters. (sonic-net#2606) [Sambath Kumar Balasubramanian] * 34995f1 2023-01-10 | Revert "[voq][chassis]Add show fabric counters port/queue commands (sonic-net#2522)" (sonic-net#2612) [Arvindsrinivasan Lakshmi Narasimhan] sairedis: * 92e6442 2023-01-05 | enable cisco8000 SAI bulk API feature (sonic-net#1153) (sonic-net#1164) (github/202205) [Keith Lu] platform-daemons: * 10eb2e6 2023-01-06 | Fix bug where transceiver info is missing after port breakout change (sonic-net#329) (HEAD -> 202205) [Tal Berlowitz] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…omatically (#25744) #### Why I did it src/sonic-swss-common ``` * 79b6b11 - (HEAD -> 202511, origin/202511) Create a new PORT_PHY_ATTR table (sonic-net#1153) (20 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
The current way to check whether the fan speed was set to default when thermal control algorithm suspended is to check it every 10s and if true will stop, considering the facts that after hw-mgmt set the algorithm and the fan speed to the default value, the algorithm need do some clean up and then stop to work, during this time it could change the fan speed, so hw-mgmt will keep monitoring the fan speed and will set it again if it changed, only after a while(may more than 2m) it can be stable. So change the way to wait for 300s to make sure fan speed set to default and not change anymore.
Type of change
Approach
How did you do it?
using sleep() to replace wait_until for checking fan speed.
How did you verify/test it?
run various reboot test.
Any platform specific information?
this change only applied to Mellanox specific test
Supported testbed topology if it's a new test case?
support all topology.
Documentation