Add GCU test cases for k8s table by lixiaoyuner · Pull Request #11458 · sonic-net/sonic-mgmt

lixiaoyuner · 2024-01-31T14:26:32Z

Description of PR

Summary:
Fixes # (issue)
Testcase of k8s config for generic updater apply-patch
ADO: 26662927

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

This PR is to verify the usage of 'config apply-patch' works for k8s config

How did you do it?

Add k8s config to dut and check if config changes as expected

How did you verify/test it?

Run test of sonic-mgmt/tests/generic_config_updater/test_kubernetes_config.py on KVM

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2024-01-31T14:27:45Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/test_kubernetes_config.py check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/generic_config_updater/test_kubernetes_config.py:21:121: E501 line too long (149 > 120 characters) tests/generic_config_updater/test_kubernetes_config.py:22:121: E501 line too long (151 > 120 characters) tests/generic_config_updater/test_kubernetes_config.py:28:21: E128 continuation line under-indented for visual indent tests/generic_config_updater/test_kubernetes_config.py:30:21: E128 continuation line under-indented for visual indent tests/generic_config_updater/test_kubernetes_config.py:32:121: E501 line too long (133 > 120 characters) ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2024-01-31T16:23:13Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/test_kubernetes_config.py fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Passed flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

wen587 · 2024-02-01T09:44:24Z

tests/generic_config_updater/test_kubernetes_config.py

+        delete_checkpoint(duthost)
+
+
+def get_k8s_runningconfig(duthost):


Any other check method other than running config?
The success of apply-patch operation should guarantee the CONFIG_DB update.
Is there a show command such as show k8s server?

Thanks for this comment, have add 'show kube server' related validation.

wen587

LGTM

qiluo-msft · 2024-02-05T22:11:29Z

tests/generic_config_updater/test_kubernetes_config.py

+
+
+test_data_1 = {
+    0: (K8SEMPTYTOHALFPATCH, K8SHALFCONFIG, EMPTYK8STABLE, SUCCEED),


0

Maintaining the index is not necessary. Could you remove? #Closed

Thanks for this comment, fixed.

StormLiangMS · 2024-03-05T01:16:16Z

hi @lixiaoyuner could you run test with 202305 image with this one? Would like to avoid regression for 202305 branch at this stage.

lixiaoyuner · 2024-03-05T11:26:29Z

hi @lixiaoyuner could you run test with 202305 image with this one? Would like to avoid regression for 202305 branch at this stage.

Have tested with 202305 latest image, it's good to run this test. And also tested with 202311 latest image, it's good to run this test.

## Description of PR Summary: Fixes # (issue) Testcase of k8s config for generic updater apply-patch ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ## Approach #### What is the motivation for this PR? This PR is to verify the usage of 'config apply-patch' works for k8s config #### How did you do it? Add k8s config to dut and check if config changes as expected #### How did you verify/test it? Run test of sonic-mgmt/tests/generic_config_updater/test_kubernetes_config.py on KVM

mssonicbld · 2024-03-05T12:02:02Z

Cherry-pick PR to 202305: #11901

## Description of PR Summary: Fixes # (issue) Testcase of k8s config for generic updater apply-patch ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ## Approach #### What is the motivation for this PR? This PR is to verify the usage of 'config apply-patch' works for k8s config #### How did you do it? Add k8s config to dut and check if config changes as expected #### How did you verify/test it? Run test of sonic-mgmt/tests/generic_config_updater/test_kubernetes_config.py on KVM

mssonicbld · 2024-03-05T12:02:05Z

Cherry-pick PR to 202311: #11902

## Description of PR Summary: Fixes # (issue) Testcase of k8s config for generic updater apply-patch ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ## Approach #### What is the motivation for this PR? This PR is to verify the usage of 'config apply-patch' works for k8s config #### How did you do it? Add k8s config to dut and check if config changes as expected #### How did you verify/test it? Run test of sonic-mgmt/tests/generic_config_updater/test_kubernetes_config.py on KVM

anamehra · 2024-05-17T23:47:22Z

Hi @lixiaoyuner , with this new testcase on a KUBERNETES enabled build, we observed following loganalyzer errors:

               Match Messages:
E               Apr 26 04:49:06.951797 bjw-can-8102-1 ERR ctrmgrd.py: Refer file /tmp/tmpj2csr7f7kube_hints_ for troubleshooting tips
E               
E               Apr 26 04:49:06.952134 bjw-can-8102-1 ERR ctrmgrd.py: Join failed: HTTPSConnectionPool(host='k8svip.ap.gbl', port=6443): Max retries exceeded with url: /api/v1/namespaces/default/configmaps/kube-root-ca.crt (Caused by NameResolutionError("&lt;urllib3.connection.HTTPSConnection object at 0x7fce9a825250&gt;: Failed to resolve 'k8svip.ap.gbl' ([Errno -3] Temporary failure in name resolution)"))
E               
E               Apr 26 04:49:46.964672 bjw-can-8102-1 ERR ctrmgrd.py: Refer file /tmp/tmp4r0omiobkube_hints_ for troubleshooting tips
E               
E               Apr 26 04:49:46.964855 bjw-can-8102-1 ERR ctrmgrd.py: Join failed: HTTPSConnectionPool(host='k8svip.ap.gbl', port=6443): Max retries exceeded with url: /api/v1/namespaces/default/configmaps/kube-root-ca.crt (Caused by NameResolutionError("&lt;urllib3.connection.HTTPSConnection object at 0x7fce9a825c70&gt;: Failed to resolve 'k8svip.ap.gbl' ([Errno -3] Temporary failure in name resolution)"))
E

I see the testcase using the hostname 'k8svip.ap.gbl'. What is the expectation with the test environment?

Thanks!

lixiaoyuner · 2024-05-20T09:45:37Z

Hi @lixiaoyuner , with this new testcase on a KUBERNETES enabled build, we observed following loganalyzer errors:

               Match Messages:
E               Apr 26 04:49:06.951797 bjw-can-8102-1 ERR ctrmgrd.py: Refer file /tmp/tmpj2csr7f7kube_hints_ for troubleshooting tips
E               
E               Apr 26 04:49:06.952134 bjw-can-8102-1 ERR ctrmgrd.py: Join failed: HTTPSConnectionPool(host='k8svip.ap.gbl', port=6443): Max retries exceeded with url: /api/v1/namespaces/default/configmaps/kube-root-ca.crt (Caused by NameResolutionError("&lt;urllib3.connection.HTTPSConnection object at 0x7fce9a825250&gt;: Failed to resolve 'k8svip.ap.gbl' ([Errno -3] Temporary failure in name resolution)"))
E               
E               Apr 26 04:49:46.964672 bjw-can-8102-1 ERR ctrmgrd.py: Refer file /tmp/tmp4r0omiobkube_hints_ for troubleshooting tips
E               
E               Apr 26 04:49:46.964855 bjw-can-8102-1 ERR ctrmgrd.py: Join failed: HTTPSConnectionPool(host='k8svip.ap.gbl', port=6443): Max retries exceeded with url: /api/v1/namespaces/default/configmaps/kube-root-ca.crt (Caused by NameResolutionError("&lt;urllib3.connection.HTTPSConnection object at 0x7fce9a825c70&gt;: Failed to resolve 'k8svip.ap.gbl' ([Errno -3] Temporary failure in name resolution)"))
E

I see the testcase using the hostname 'k8svip.ap.gbl'. What is the expectation with the test environment?

Thanks!

@anamehra , actually it's a fake hostname, not a real endpoint. For this case, just want to test the GCU command to update k8s table config. And there is PR to ignore the error, #12849. Any more concerns about this?

Add GCU test cases for k8s table

d83586f

Fix code format issues

814c629

lixiaoyuner added 2 commits February 1, 2024 10:40

Fix format issue

335c738

Refine the test case

afb0cdc

lixiaoyuner marked this pull request as ready for review February 1, 2024 09:31

wen587 reviewed Feb 1, 2024

View reviewed changes

Fix comments

bd2b59f

wen587 approved these changes Feb 5, 2024

View reviewed changes

wen587 requested review from ganglyu, isabelmsft and qiluo-msft February 5, 2024 09:36

qiluo-msft reviewed Feb 5, 2024

View reviewed changes

Remove the unnecessary test case index

cf2aa07

qiluo-msft approved these changes Feb 7, 2024

View reviewed changes

qiluo-msft merged commit 5ec10c4 into sonic-net:master Feb 7, 2024

wen587 added Request for 202305 branch Request for 202311 branch labels Feb 7, 2024

StormLiangMS added Approved for 202305 branch Approved for 202311 branch labels Mar 5, 2024

mssonicbld added the Created PR to 202305 branch label Mar 5, 2024

mssonicbld added the Created PR to 202311 branch label Mar 5, 2024

mssonicbld mentioned this pull request Mar 5, 2024

[action] [PR:11458] Add GCU test cases for k8s table #11901

Merged

8 tasks

mssonicbld mentioned this pull request Mar 5, 2024

[action] [PR:11458] Add GCU test cases for k8s table #11902

Merged

8 tasks

mssonicbld added Included in 202311 branch Included in 202305 branch and removed Created PR to 202311 branch Created PR to 202305 branch labels Mar 5, 2024

		delete_checkpoint(duthost)


		def get_k8s_runningconfig(duthost):



		test_data_1 = {
		0: (K8SEMPTYTOHALFPATCH, K8SHALFCONFIG, EMPTYK8STABLE, SUCCEED),

Conversation

lixiaoyuner commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Jan 31, 2024

Uh oh!

mssonicbld commented Jan 31, 2024

Uh oh!

wen587 Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

lixiaoyuner Feb 5, 2024

Choose a reason for hiding this comment

Uh oh!

wen587 left a comment

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Feb 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lixiaoyuner Feb 6, 2024

Choose a reason for hiding this comment

Uh oh!

StormLiangMS commented Mar 5, 2024

Uh oh!

lixiaoyuner commented Mar 5, 2024

Uh oh!

mssonicbld commented Mar 5, 2024

Uh oh!

mssonicbld commented Mar 5, 2024

Uh oh!

anamehra commented May 17, 2024

Uh oh!

lixiaoyuner commented May 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lixiaoyuner commented Jan 31, 2024 •

edited

Loading

qiluo-msft Feb 5, 2024 •

edited

Loading

lixiaoyuner commented May 20, 2024 •

edited

Loading