[Crm/test_crm_nexthop]: Fix test_crm_nexthop testcase due to all inte…#11294
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jan 19, 2024
Merged
[Crm/test_crm_nexthop]: Fix test_crm_nexthop testcase due to all inte…#11294wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
…rfaces in down state
Blueve
approved these changes
Jan 19, 2024
wangxin
approved these changes
Jan 19, 2024
Collaborator
|
Cherry-pick PR to 202311: #11340 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 19, 2024
…ate (sonic-net#11294) What is the motivation for this PR? In the PR - sonic-net#8051: There was a new fixture added to shut down all interfaces before the testcase (test_crm_nexthop) starts. This however does not work well for test_crm_nexthop testcase. This testcase adds a static route via one of the ptf interfaces(ethernet1). The interface which is directly connected to the PTF's interface needs to be up in order for the added static route to be effective. Only if it is up, the crm resources will be utilized and the used and available counter for ipv4_nexthop will be incremented and decremented respectively. Since all interfaces are shut down, the static route added by this testcase wont be effective and hence will not use any crm resources. How did you do it? The fix here is to bring up the interface used in the testcase so that the static route added will be in effect and the crm resource will be utilized. Since the interface in test is "Ethernet1", code is added to bring this interface up and then continue the testcase. How did you verify/test it? Ran test_crm_nexthop to see if the testcase passes both ipv4 and ipv6 cases.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 19, 2024
…ate (sonic-net#11294) What is the motivation for this PR? In the PR - sonic-net#8051: There was a new fixture added to shut down all interfaces before the testcase (test_crm_nexthop) starts. This however does not work well for test_crm_nexthop testcase. This testcase adds a static route via one of the ptf interfaces(ethernet1). The interface which is directly connected to the PTF's interface needs to be up in order for the added static route to be effective. Only if it is up, the crm resources will be utilized and the used and available counter for ipv4_nexthop will be incremented and decremented respectively. Since all interfaces are shut down, the static route added by this testcase wont be effective and hence will not use any crm resources. How did you do it? The fix here is to bring up the interface used in the testcase so that the static route added will be in effect and the crm resource will be utilized. Since the interface in test is "Ethernet1", code is added to bring this interface up and then continue the testcase. How did you verify/test it? Ran test_crm_nexthop to see if the testcase passes both ipv4 and ipv6 cases.
Merged
7 tasks
Collaborator
|
Cherry-pick PR to 202305: #11341 |
Collaborator
|
Cherry-pick PR to 202205: #11342 |
mssonicbld
pushed a commit
that referenced
this pull request
Jan 19, 2024
…ate (#11294) What is the motivation for this PR? In the PR - #8051: There was a new fixture added to shut down all interfaces before the testcase (test_crm_nexthop) starts. This however does not work well for test_crm_nexthop testcase. This testcase adds a static route via one of the ptf interfaces(ethernet1). The interface which is directly connected to the PTF's interface needs to be up in order for the added static route to be effective. Only if it is up, the crm resources will be utilized and the used and available counter for ipv4_nexthop will be incremented and decremented respectively. Since all interfaces are shut down, the static route added by this testcase wont be effective and hence will not use any crm resources. How did you do it? The fix here is to bring up the interface used in the testcase so that the static route added will be in effect and the crm resource will be utilized. Since the interface in test is "Ethernet1", code is added to bring this interface up and then continue the testcase. How did you verify/test it? Ran test_crm_nexthop to see if the testcase passes both ipv4 and ipv6 cases.
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Jan 19, 2024
…ate (#11294) What is the motivation for this PR? In the PR - #8051: There was a new fixture added to shut down all interfaces before the testcase (test_crm_nexthop) starts. This however does not work well for test_crm_nexthop testcase. This testcase adds a static route via one of the ptf interfaces(ethernet1). The interface which is directly connected to the PTF's interface needs to be up in order for the added static route to be effective. Only if it is up, the crm resources will be utilized and the used and available counter for ipv4_nexthop will be incremented and decremented respectively. Since all interfaces are shut down, the static route added by this testcase wont be effective and hence will not use any crm resources. How did you do it? The fix here is to bring up the interface used in the testcase so that the static route added will be in effect and the crm resource will be utilized. Since the interface in test is "Ethernet1", code is added to bring this interface up and then continue the testcase. How did you verify/test it? Ran test_crm_nexthop to see if the testcase passes both ipv4 and ipv6 cases.
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
wangxin
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 22, 2024
…ate (sonic-net#11294) What is the motivation for this PR? In the PR - sonic-net#8051: There was a new fixture added to shut down all interfaces before the testcase (test_crm_nexthop) starts. This however does not work well for test_crm_nexthop testcase. This testcase adds a static route via one of the ptf interfaces(ethernet1). The interface which is directly connected to the PTF's interface needs to be up in order for the added static route to be effective. Only if it is up, the crm resources will be utilized and the used and available counter for ipv4_nexthop will be incremented and decremented respectively. Since all interfaces are shut down, the static route added by this testcase wont be effective and hence will not use any crm resources. How did you do it? The fix here is to bring up the interface used in the testcase so that the static route added will be in effect and the crm resource will be utilized. Since the interface in test is "Ethernet1", code is added to bring this interface up and then continue the testcase. How did you verify/test it? Ran test_crm_nexthop to see if the testcase passes both ipv4 and ipv6 cases.
mssonicbld
pushed a commit
that referenced
this pull request
Jan 22, 2024
…ate (#11294) What is the motivation for this PR? In the PR - #8051: There was a new fixture added to shut down all interfaces before the testcase (test_crm_nexthop) starts. This however does not work well for test_crm_nexthop testcase. This testcase adds a static route via one of the ptf interfaces(ethernet1). The interface which is directly connected to the PTF's interface needs to be up in order for the added static route to be effective. Only if it is up, the crm resources will be utilized and the used and available counter for ipv4_nexthop will be incremented and decremented respectively. Since all interfaces are shut down, the static route added by this testcase wont be effective and hence will not use any crm resources. How did you do it? The fix here is to bring up the interface used in the testcase so that the static route added will be in effect and the crm resource will be utilized. Since the interface in test is "Ethernet1", code is added to bring this interface up and then continue the testcase. How did you verify/test it? Ran test_crm_nexthop to see if the testcase passes both ipv4 and ipv6 cases.
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rfaces in down state
Description of PR
This PR fixes the testcase test_crm_nexthop failure due to #8051
Type of change
Back port request
Approach
What is the motivation for this PR?
In the PR - #8051: There was a new fixture added to shut down all interfaces before the testcase (test_crm_nexthop) starts. This however does not work well for test_crm_nexthop testcase. This testcase adds a static route via one of the ptf interfaces(ethernet1). The interface which is directly connected to the PTF's interface needs to be up in order for the added static route to be effective. Only if it is up, the crm resources will be utilized and the used and available counter for ipv4_nexthop will be incremented and decremented respectively. Since all interfaces are shut down, the static route added by this testcase wont be effective and hence will not use any crm resources.
How did you do it?
The fix here is to bring up the interface used in the testcase so that the static route added will be in effect and the crm resource will be utilized. Since the interface in test is "Ethernet1", code is added to bring this interface up and then continue the testcase.
How did you verify/test it?
Ran test_crm_nexthop to see if the testcase passes both ipv4 and ipv6 cases.
Any platform specific information?
NA
Supported testbed topology if it's a new test case?
NA
Documentation
NA