Fix wrong skip condition in test_decap on 7260CX3#11203
Merged
StormLiangMS merged 2 commits intosonic-net:masterfrom Jan 5, 2024
Merged
Fix wrong skip condition in test_decap on 7260CX3#11203StormLiangMS merged 2 commits intosonic-net:masterfrom
StormLiangMS merged 2 commits intosonic-net:masterfrom
Conversation
kevinskwang
reviewed
Jan 5, 2024
tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
Outdated
Show resolved
Hide resolved
kevinskwang
approved these changes
Jan 5, 2024
Collaborator
|
@wsycqyz PR conflicts with 202305 branch |
7 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Jan 11, 2024
What is the motivation for this PR? Cherry pick #11203 How did you do it? How did you verify/test it? Any platform specific information?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes error skip condition introduced by #10599
Type of change
Back port request
Approach
What is the motivation for this PR?
7260CX3 with test_decap should be skipped now
How did you do it?
Add skip condition
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation