Skip to content

[simple-fib] Fixes vm CPU hog issue in ECMP test. #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephenxs wants to merge 2 commits into from
Closed

[simple-fib] Fixes vm CPU hog issue in ECMP test. #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9a6728
[simple-fib] Fix vm CPU hog issue in ECMP test.
Sep 6, 2019
51c8854
[fib_test.py] add more information when assert failure
Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ansible/roles/test/files/ptftests/fib_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ def check_balancing(self, dest_port_list, port_hit_cnt):
% ("LAG", str(member), total_entry_hit_cnt/len(ecmp_entry), port_hit_cnt.get(member, 0), str(round(p, 4)*100) + '%'))
result &= r

assert result
assert result, "dest port list {}, port hit count {}".format(dest_port_list, port_hit_cnt)

#---------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion ansible/roles/test/tasks/simple-fib.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

- debug : msg="Start FIB Test"

- set_fact: mtu=9114
- set_fact: mtu=1500
Copy link
Copy Markdown
Contributor

@prsunny prsunny Sep 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a configurable parameter. Can we have this default to 9100 and in your test modify to 1500?. Prefer to keep the default as 9100.

Copy link
Copy Markdown
Contributor Author

@stephenxs stephenxs Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. It's a better option. Then I will close this PR.

when: mtu is not defined

- name: "Start PTF runner"
Expand Down