QoSHdrmPoolsize _tx_disable_enable for all destination ports in lag

[ansrajpu-git]

Description of PR

Summary:
Since testQosHeadroomPoolsize test takes more than one source port as input, even after tx disable, the packets could still hash from the other ports. Hence tx_disable has to be applied on all ports in the destination lag to block all the traffic during tx_disable.
Fixes # (issue)

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 201911
• 202012
• 202205
• 202305

Approach

Since testQosHeadroomPoolsize test takes more than one source port as input, even after tx disable, the packets could still hash from the other ports. Hence tx_disable has to be applied on all ports in the destination lag to block all the traffic during tx_disable.
This was achieved by
-Collecting all the dst_port_ids ports associated with the src_port_ids
-Sending all the dst_port_ids in a list, instead of sending a single dst_port_id in tx_disable

What is the motivation for this PR?

Intermitted failure of testQosHdrmPoolsize test

How did you do it?

Executed Qos test suite and verify the results

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[ansrajpu-git]

@vmittal-msft , kindly verify & approve

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/saitests/py3/sai_qos_tests.py:2731:9: E303 too many blank lines (2)
tests/saitests/py3/sai_qos_tests.py:2854:73: E225 missing whitespace around operator

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[vmittal-msft]

Can you please clarify why dst ports and dependent on src_port_id ? Should we check if destination port is part of the lag then disable all ports under that lag ?

[vmittal-msft]

Also, Can we have this specific to dnx chassis ?

[ansrajpu-git]

done

[vmittal-msft]

same as above

[ansrajpu-git]

done

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/saitests/py3/sai_qos_tests.py:2759:9: F841 local variable 'asic_type' is assigned to but never used

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[arlakshm]

add @kenneth-arista, @ysmanman for viz..

[vmittal-msft]

@yxieca @wangxin please help merge.

[arlakshm]

Hi @kenneth-arista, @ysmanman can you please take a look at this PR and check if this changes works on single asic LCs are well

[StormLiangMS]

hi @ansrajpu-git @vmittal-msft the PR, #8775, which breaks the testQosSaiHeadroomPoolWatermark for box devices due to wrong intent in line 2386. And in current PR it seems changed this part, could you pls verify the change on ToR / Leaf before merge?

[mssonicbld]

Cherry-pick PR to 202311: #12024

[mssonicbld]

Cherry-pick PR to 202305: #12025

[ansrajpu-git]

@vmittal-msft, please help this merge to 202205 branch.