[nic_simulator] Add missing attribute in the slot#11006
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Dec 14, 2023
Merged
[nic_simulator] Add missing attribute in the slot#11006StormLiangMS merged 1 commit intosonic-net:masterfrom
StormLiangMS merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Longxiang Lyu <[email protected]>
yxieca
approved these changes
Dec 13, 2023
Collaborator
|
What problem are you fixing? Can you add more details regarding the consequences of not having these attributes? |
Collaborator
Author
@yxieca, all member attributes should be listed in |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 14, 2023
What is the motivation for this PR? As the subject. How did you do it? Add packet_filter and drop to the attribute list. How did you verify/test it? Run nic_simulator Any platform specific information?
Collaborator
|
Cherry-pick PR to 202305: #11014 |
7 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 14, 2023
What is the motivation for this PR? As the subject. How did you do it? Add packet_filter and drop to the attribute list. How did you verify/test it? Run nic_simulator Any platform specific information?
Collaborator
|
Cherry-pick PR to 202205: #11015 |
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 26, 2024
What is the motivation for this PR? As the subject. How did you do it? Add packet_filter and drop to the attribute list. How did you verify/test it? Run nic_simulator Any platform specific information?
mssonicbld
pushed a commit
that referenced
this pull request
Jan 26, 2024
What is the motivation for this PR? As the subject. How did you do it? Add packet_filter and drop to the attribute list. How did you verify/test it? Run nic_simulator Any platform specific information?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
As the subject.
How did you do it?
Add
packet_filteranddropto the attribute list.How did you verify/test it?
Run
nic_simulatorAny platform specific information?
Supported testbed topology if it's a new test case?
Documentation