[warm-reboot] Fix trying to access match group when regex match failed#1095
Merged
neethajohn merged 1 commit intosonic-net:masterfrom Sep 10, 2019
Merged
Conversation
Signed-off-by: Neetha John <[email protected]>
yxieca
approved these changes
Sep 5, 2019
yxieca
pushed a commit
that referenced
this pull request
Sep 11, 2019
Signed-off-by: Neetha John <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Add ip_prefix len based on proxy_arp status (sonic-net#1096) [sonic-cfggen][QoS][multi ASIC] Multi ASIC QoS and Buffer config generation support, merge from master (sonic-net#1095) Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neetha John [email protected]
Description of PR
Prior to the fix, the code was trying to access a regexp match group when match fails.
Type of change
Approach
How did you do it?
Use the portchannel name directly instead of using match.group()
How did you verify/test it?
Ran the warm reboot sad path lag testcase with the change and it passed
Any platform specific information?
Supported testbed topology if it's a new test case?