Macsec fix for portchannel workaround only for Broadcom dnx platforms#10732
Merged
abdosi merged 27 commits intosonic-net:masterfrom Nov 15, 2023
Merged
Macsec fix for portchannel workaround only for Broadcom dnx platforms#10732abdosi merged 27 commits intosonic-net:masterfrom
abdosi merged 27 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
chassis Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
inner ipv6 test case Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
…or modular" This reverts commit fe770ed.
…v4 and" This reverts commit d044f9f.
for dnx platforms. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Contributor
Author
|
@judyjoseph please help review of this |
judyjoseph
approved these changes
Nov 15, 2023
Collaborator
|
Cherry-pick PR to 202305: #10792 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 20, 2023
…sonic-net#10732) What I did: macsec workaround for portchannel as define here sonic-net/sonic-swss#2286 applies only to dnx platforms. This workaround causes failure of macsec bgp protocol testcase on platforms that does not need this workaround. How I verify: Test case passes after this change.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 20, 2023
…sonic-net#10732) What I did: macsec workaround for portchannel as define here sonic-net/sonic-swss#2286 applies only to dnx platforms. This workaround causes failure of macsec bgp protocol testcase on platforms that does not need this workaround. How I verify: Test case passes after this change.
Collaborator
|
Cherry-pick PR to 202205: #10793 |
This was referenced Nov 20, 2023
Merged
mssonicbld
pushed a commit
that referenced
this pull request
Nov 20, 2023
…#10732) What I did: macsec workaround for portchannel as define here sonic-net/sonic-swss#2286 applies only to dnx platforms. This workaround causes failure of macsec bgp protocol testcase on platforms that does not need this workaround. How I verify: Test case passes after this change.
mssonicbld
pushed a commit
that referenced
this pull request
Nov 20, 2023
…#10732) What I did: macsec workaround for portchannel as define here sonic-net/sonic-swss#2286 applies only to dnx platforms. This workaround causes failure of macsec bgp protocol testcase on platforms that does not need this workaround. How I verify: Test case passes after this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
macsec workaround for portchannel as define here sonic-net/sonic-swss#2286 applies only to dnx platforms.
This workaround causes failure of macsec bgp protocol testcase on platforms that does not need this workaround.
How I verify:
Test case passes after this change.