Make the VM reboot command async and ignore its errors#1073
Merged
pavel-shirshov merged 1 commit intosonic-net:masterfrom Aug 22, 2019
wangxin:vm_reboot_issue
Merged
Make the VM reboot command async and ignore its errors#1073pavel-shirshov merged 1 commit intosonic-net:masterfrom wangxin:vm_reboot_issue
pavel-shirshov merged 1 commit intosonic-net:masterfrom
wangxin:vm_reboot_issue
Conversation
The command for rebooting VM was executed synchronously. Sometimes it could fail because the VM closed the SSH connection before ansible finishes the reboot command. The fix is to make the command async and ignore its errors. Signed-off-by: Xin Wang <[email protected]>
pavel-shirshov
approved these changes
Aug 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
The command for rebooting VM was executed synchronously.
Sometimes it could fail because the VM closed the SSH connection
before ansible finishes the reboot command. The fix is to make
the command async and ignore its errors.
Signed-off-by: Xin Wang [email protected]
Type of change
Approach
How did you do it?
Make the command for rebooting VM async and ignore its errors.
How did you verify/test it?
Tested using
testbed-cli.sh add-topo.Any platform specific information?
NA
Supported testbed topology if it's a new test case?
NA
Documentation