Skip to content

Fix test_fbd.py flaky result#10682

Merged
wsycqyz merged 2 commits intosonic-net:masterfrom
wsycqyz:bfd-master
Nov 9, 2023
Merged

Fix test_fbd.py flaky result#10682
wsycqyz merged 2 commits intosonic-net:masterfrom
wsycqyz:bfd-master

Conversation

@wsycqyz
Copy link
Copy Markdown
Contributor

@wsycqyz wsycqyz commented Nov 8, 2023

Description of PR

Summary:
Fixes test_fbd.py flaky result

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

The result of test_bfd.py is flaky.

How did you do it?

Increase sleep time before check bfd status.

How did you verify/test it?

Run 300 time and 100% pass on Cisco platform

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wsycqyz
Copy link
Copy Markdown
Contributor Author

wsycqyz commented Nov 8, 2023

202305 branch will be in another PR.

@mssonicbld
Copy link
Copy Markdown
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/bfd/test_bfd.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@wsycqyz wsycqyz mentioned this pull request Nov 8, 2023
7 tasks
Copy link
Copy Markdown
Contributor

@XuChen-MSFT XuChen-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wsycqyz wsycqyz merged commit 3b22a0c into sonic-net:master Nov 9, 2023
yejianquan pushed a commit that referenced this pull request Nov 9, 2023
Description of PR
Summary:
Fixes test_fbd.py flaky result
This is double commit of #10682

co-authorized by: [email protected]
@wsycqyz wsycqyz deleted the bfd-master branch November 13, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants