[action] [PR:10206] [chassis] [MA] Route flap fix#10553
Merged
mssonicbld merged 1 commit intosonic-net:202205from Nov 4, 2023
Merged
[action] [PR:10206] [chassis] [MA] Route flap fix#10553mssonicbld merged 1 commit intosonic-net:202205from
mssonicbld merged 1 commit intosonic-net:202205from
Conversation
6 tasks
Collaborator
Author
|
Original PR: #10206 |
Collaborator
Author
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fix issue for packet chassis.
For VOQ chassis or other multi-asic duts, we were using VOQ_INBAND_INTERFACE and BGP_INTERNAL_NEIGHBOR to exclude internal interfaces in this test. However, packet chassis internal interfaces/portchannels do not have any IP associated with them.
Changes in this PR:
dev_portwe get is external port again by usingshow ip intand grep for this dev_port,show ip intwithout-d allwill not have internal links. Ideally the dev_port should already be an external link, but if there is any multi-asic device that does not have point#1 and point#2 above, this check will get hit and we skip applying this port todev_port.Note that by using
grep -wwe will be doing complete word match.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
verified on one linecard of packet chassis.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation