Skip to content

[action] [PR:10206] [chassis] [MA] Route flap fix#10553

Merged
mssonicbld merged 1 commit intosonic-net:202205from
mssonicbld:cherry/202205/10206
Nov 4, 2023
Merged

[action] [PR:10206] [chassis] [MA] Route flap fix#10553
mssonicbld merged 1 commit intosonic-net:202205from
mssonicbld:cherry/202205/10206

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

Fix issue for packet chassis.
For VOQ chassis or other multi-asic duts, we were using VOQ_INBAND_INTERFACE and BGP_INTERNAL_NEIGHBOR to exclude internal interfaces in this test. However, packet chassis internal interfaces/portchannels do not have any IP associated with them.
Changes in this PR:

  1. not use BGP_INTERNAL_NEIGHBOR, use PORTCHANNEL_MEMBER for MA dut and packet chassis, to get internal interfaces.
  2. voq chassis continue to use VOQ_INBAND_INTERFACE
  3. remove the check for single-asic devices, they don't have internal links, no need to check.
  4. after filtering out internal links, confirm the dev_port we get is external port again by using show ip int and grep for this dev_port, show ip int without -d all will not have internal links. Ideally the dev_port should already be an external link, but if there is any multi-asic device that does not have point#1 and point#2 above, this check will get hit and we skip applying this port to dev_port.
    Note that by using grep -w we will be doing complete word match.
e.g. 
admin@masic-lc:~$ show ip int | grep -w PortChannel102
PortChannel102 xxx/31 up/up xxxT3 10.0.0.1
admin@masic-lc:~$ show ip int | grep -w PortChannel1
admin@masic-lc:~$

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

verified on one linecard of packet chassis.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #10206

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run Azure.sonic-mgmt

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run Azure.sonic-mgmt

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run Azure.sonic-mgmt

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 50c9e70 into sonic-net:202205 Nov 4, 2023
@mssonicbld mssonicbld deleted the cherry/202205/10206 branch February 4, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants