[action] [PR:10286] Avoid running command in exited ptf docker container#10524
Merged
mssonicbld merged 1 commit intosonic-net:202305from Oct 30, 2023
Merged
[action] [PR:10286] Avoid running command in exited ptf docker container#10524mssonicbld merged 1 commit intosonic-net:202305from
mssonicbld merged 1 commit intosonic-net:202305from
Conversation
6 tasks
Collaborator
Author
|
Original PR: #10286 |
While stopping PTF container, "ptf_control" module is executed to kill all processes in the PTF container. The original code checks if the PTF container's Pid exists before running command in the PTF container. Unfortunately, this check is not enough. PTF docker container in exited status still has Pid. This change improved the code for getting PTF container's Pid. When PTF container is not in "running" status, always return None for PTF container's Pid. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
mssonicbld
force-pushed
the
cherry/202305/10286
branch
from
31cc5a9 to
f1b682d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
While stopping PTF container, "ptf_control" module is executed to kill all processes in the PTF container.
The original code checks if the PTF container's Pid exists before running command in the PTF container. Unfortunately, this check is not enough. PTF docker container in exited status still has Pid.
How did you do it?
This change improved the code for getting PTF container's Pid. When PTF container is not in "running" status, always return None for PTF container's Pid.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation